From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] Fix crash on NULL rl_prompt
Date: Tue, 30 Mar 2010 16:12:00 -0000 [thread overview]
Message-ID: <201003301712.20874.pedro@codesourcery.com> (raw)
In-Reply-To: <m37hotztsn.fsf@fleche.redhat.com>
On Tuesday 30 March 2010 16:57:28, Tom Tromey wrote:
> Jan> BTW don't you think xstrdup (NULL) should == NULL? Like xmalloc
> Jan> (0) == NULL.
While it is implementation defined if malloc(0) returns NULL or
not, xmalloc(0) never returns NULL. Quite the opposite.
It makes sure to never call malloc with size 0.
I don't think that xstrdup should special case NULL input.
It will tend to mask out bugs. It isn't clear to me your
patch isn't doing so, FTR. It could have been a readline
change only visible when using a more recent system
readline, instead of the version bundled with gdb, for
example.
--
Pedro Alves
next prev parent reply other threads:[~2010-03-30 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 23:40 Jan Kratochvil
2010-03-30 15:57 ` Tom Tromey
2010-03-30 16:12 ` Pedro Alves [this message]
2010-03-30 16:23 ` Tom Tromey
2010-03-30 16:41 ` Pedro Alves
2010-03-30 17:05 ` Jan Kratochvil
2010-03-30 17:13 ` Tom Tromey
2010-03-30 17:25 ` Pedro Alves
2010-03-30 17:29 ` Jan Kratochvil
2010-03-30 17:55 ` Pedro Alves
2010-03-31 21:27 ` [cancel] " Jan Kratochvil
2010-03-30 17:31 ` Tom Tromey
2010-03-30 20:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003301712.20874.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox