From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5887 invoked by alias); 31 Mar 2010 21:27:59 -0000 Received: (qmail 5874 invoked by uid 22791); 31 Mar 2010 21:27:58 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Mar 2010 21:27:54 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2VLMBSP012090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 31 Mar 2010 17:22:12 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2VLM81o007250 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 31 Mar 2010 17:22:10 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o2VLM7ot014142; Wed, 31 Mar 2010 23:22:07 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o2VLM7A0014137; Wed, 31 Mar 2010 23:22:07 +0200 Date: Wed, 31 Mar 2010 21:27:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: [cancel] Re: [patch] Fix crash on NULL rl_prompt Message-ID: <20100331212206.GA13903@host0.dyn.jankratochvil.net> References: <20100329234026.GA23895@host0.dyn.jankratochvil.net> <201003301825.18754.pedro@codesourcery.com> <20100330172940.GA17534@host0.dyn.jankratochvil.net> <201003301855.08267.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201003301855.08267.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01121.txt.bz2 On Tue, 30 Mar 2010 19:55:08 +0200, Pedro Alves wrote: > On Tuesday 30 March 2010 18:30:48, Tom Tromey wrote: > > We can always un-approve it, if you would rather wait to see if a > > reproducer is available. > > I'll leave it up to you to decide. But if this goes in, > perhaps a comment saying this is being defensive would be good. Found the problem was most probably due to a Fedora patch posted here without the FSF GDB acceptance intention: [gdb FYI-patch] callback-mode readline-6.0 regression http://sourceware.org/ml/gdb-patches/2009-11/msg00596.html That patch is needed only with readline-6.0 and neither with 5.1 nor 6.1. That patch accidentally did rl_set_prompt (NULL). (FSF GDB should import readline-6.1 but that is offtopic in this thread.) Therefore not going to check-in this patch. Thanks, Jan