From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28792 invoked by alias); 30 Mar 2010 17:13:38 -0000 Received: (qmail 28777 invoked by uid 22791); 30 Mar 2010 17:13:37 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 17:13:31 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2UHDMXx002595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Mar 2010 13:13:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2UHDLiZ003540; Tue, 30 Mar 2010 13:13:22 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o2UHDLK8015197; Tue, 30 Mar 2010 13:13:21 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id BA050508258; Tue, 30 Mar 2010 11:13:20 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] Fix crash on NULL rl_prompt References: <20100329234026.GA23895@host0.dyn.jankratochvil.net> <201003301712.20874.pedro@codesourcery.com> <201003301741.20844.pedro@codesourcery.com> <20100330170457.GA10938@host0.dyn.jankratochvil.net> Reply-To: Tom Tromey Date: Tue, 30 Mar 2010 17:13:00 -0000 In-Reply-To: <20100330170457.GA10938@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 30 Mar 2010 19:04:57 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01068.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Pedro> But, how did rl_prompt end up NULL in the first place? Jan> I do not know. Yeah, it is not great that we don't know how to reproduce it. But, given that part of the readline contract is that rl_prompt==NULL is a valid state, I think tui_prep_terminal ought to cope with that as well. Maybe there is also some other bug somewhere else, but that doesn't affect the correctness of this particular patch. Pedro> That's what I meant by masking out a bug. Jan> An existing bug a user cannot notice is ... no longer a bug, isn't it? I'm sympathetic to this, but I would assume that however the user got gdb into this weird state could also hypothetically reveal other latent bugs. I still think your fix is ok, but without a reproducer we can't really be sure we've fixed the problem. Tom