From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
Date: Tue, 14 Mar 2017 18:24:00 -0000 [thread overview]
Message-ID: <m37f3remxf.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <6640b187-bad5-a584-73b0-4e151a85fc3c@redhat.com> (Pedro Alves's message of "Tue, 14 Mar 2017 17:13:53 +0000")
On Tue, Mar 14 2017, Pedro Alves wrote:
> On 03/14/2017 03:44 PM, Andreas Arnez wrote:
>> Version 1 is here:
>>
>> https://sourceware.org/ml/gdb-patches/2017-03/msg00043.html
>>
>> Changes from version 1:
>>
>> * "unsigned" -> "unsigned int"
>>
>> * Compare pointers with NULL explicitly.
>
> Pedantically, it should be "if (errno != 0)" and
> "*xfered_len != 0 ? ...." as well.
OK, changed those as well.
>
>>
>> * Move the ptrace peek/poke loop to a separate routine for better
>> readability.
>>
>> OK to apply?
>
> LGTM.
Thanks!
I noticed that the commit message is now slightly wrong, because GDB now
*does* exploit writing to /proc/<pid>/mem. Fixed the commit message
accordingly.
Pushed with the above changes.
--
Andreas
next prev parent reply other threads:[~2017-03-14 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:44 Andreas Arnez
2017-03-14 17:13 ` Pedro Alves
2017-03-14 18:24 ` Andreas Arnez [this message]
2017-03-16 10:44 ` Jiong Wang
2017-03-16 14:39 ` Yao Qi
2017-03-16 15:21 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37f3remxf.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox