Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word

[Jiong Wang <jiong.wang@foss.arm.com>]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

On 14/03/17 15:44, Andreas Arnez wrote:
> +      /* Restrict to a chunk that fits in the current word.  */
> +      chunk = std::min (sizeof (PTRACE_TYPE_RET) - skip, len - n);
>
On 14/03/17 15:44, Andreas Arnez wrote:
>
> +      /* Restrict to a chunk that fits in the current word.  */
> +      chunk = std::min (sizeof (PTRACE_TYPE_RET) - skip, len - n);

Hi Andres,

I am seeing the following build failure on my local AArch32 native build:

...binutils-gdb/gdb/inf-ptrace.c:473:65: error: no matching function for call to 'min(unsigned int, ULONGEST)'

There are a few ways to fix this, this patch simply change the type of "skip" from "unsigned int" to "ULONGEST" so operands for std::min can have the same type.

OK for master?

gdb/
2017-03-16  Jiong Wang  <jiong.wang@arm.com>

         * inf-ptrace.c (inf_ptrace_peek_poke): Change the type to "ULONGEST" for
         "skip".


[-- Attachment #2: fix.patch --]
[-- Type: text/x-diff, Size: 562 bytes --]

diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c
index 32794ec132f72c261debd329196c73a4e3cff75b..431a36b8c726f8475650de00bf895b8d5f48fa83 100644
--- a/gdb/inf-ptrace.c
+++ b/gdb/inf-ptrace.c
@@ -462,7 +462,7 @@ inf_ptrace_peek_poke (pid_t pid, gdb_byte *readbuf,
   /* We transfer aligned words.  Thus align ADDR down to a word
      boundary and determine how many bytes to skip at the
      beginning.  */
-  unsigned int skip = addr & (sizeof (PTRACE_TYPE_RET) - 1);
+  ULONGEST skip = addr & (sizeof (PTRACE_TYPE_RET) - 1);
   addr -= skip;
 
   for (n = 0;