Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Jiong Wang <jiong.wang@foss.arm.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
Date: Thu, 16 Mar 2017 15:21:00 -0000	[thread overview]
Message-ID: <m3mvclcknx.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <c13d8a01-71a8-2bef-2e85-1d52edc919f2@foss.arm.com> (Jiong Wang's	message of "Thu, 16 Mar 2017 10:44:34 +0000")

On Thu, Mar 16 2017, Jiong Wang wrote:

> I am seeing the following build failure on my local AArch32 native build:
>
> ...binutils-gdb/gdb/inf-ptrace.c:473:65: error: no matching function for
> call to 'min(unsigned int, ULONGEST)'

Hm, sorry for the breakage.

> There are a few ways to fix this, this patch simply change the type of
> "skip" from "unsigned int" to "ULONGEST" so operands for std::min can have
> the same type.

Right, that's a possibility, although the reader may be confused why a
variable whose value is known to be less than 8 needs to be declared as
ULONGEST...

--
Andreas


      parent reply	other threads:[~2017-03-16 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 15:44 Andreas Arnez
2017-03-14 17:13 ` Pedro Alves
2017-03-14 18:24   ` Andreas Arnez
2017-03-16 10:44 ` Jiong Wang
2017-03-16 14:39   ` Yao Qi
2017-03-16 15:21   ` Andreas Arnez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3mvclcknx.fsf@oc1027705133.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jiong.wang@foss.arm.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox