From: Yao Qi <qiyaoltc@gmail.com>
To: Jiong Wang <jiong.wang@foss.arm.com>
Cc: Andreas Arnez <arnez@linux.vnet.ibm.com>,
gdb-patches@sourceware.org,
Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word
Date: Thu, 16 Mar 2017 14:39:00 -0000 [thread overview]
Message-ID: <86d1dhmgkg.fsf@gmail.com> (raw)
In-Reply-To: <c13d8a01-71a8-2bef-2e85-1d52edc919f2@foss.arm.com> (Jiong Wang's message of "Thu, 16 Mar 2017 10:44:34 +0000")
Jiong Wang <jiong.wang@foss.arm.com> writes:
> I am seeing the following build failure on my local AArch32 native build:
>
> ...binutils-gdb/gdb/inf-ptrace.c:473:65: error: no matching function
> for call to 'min(unsigned int, ULONGEST)'
>
> There are a few ways to fix this, this patch simply change the type of
> "skip" from "unsigned int" to "ULONGEST" so operands for std::min can
> have the same type.
>
> OK for master?
>
Yes, pleas apply, a nit below,
> gdb/
> 2017-03-16 Jiong Wang <jiong.wang@arm.com>
>
> * inf-ptrace.c (inf_ptrace_peek_poke): Change the type to "ULONGEST" for
This line is too long. The max line length of ChangeLog is 74.
> "skip".
--
Yao (齐尧)
next prev parent reply other threads:[~2017-03-16 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 15:44 Andreas Arnez
2017-03-14 17:13 ` Pedro Alves
2017-03-14 18:24 ` Andreas Arnez
2017-03-16 10:44 ` Jiong Wang
2017-03-16 14:39 ` Yao Qi [this message]
2017-03-16 15:21 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d1dhmgkg.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jiong.wang@foss.arm.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox