From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7001 invoked by alias); 16 Mar 2017 14:39:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6974 invoked by uid 89); 16 Mar 2017 14:39:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:760 X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Mar 2017 14:39:30 +0000 Received: by mail-wm0-f65.google.com with SMTP id x124so4465504wmf.3 for ; Thu, 16 Mar 2017 07:39:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=cqAziQgWwrJp7t6GPv4UPg4ZPashAqqu4esN4SKtJFM=; b=QtWm72sGKUbAWOejIv/tC52vjg+2AtsGVoRNy73JM/DiItbcBvOUQbUijWP+iLOF+2 DTXiu//HcDkfcEU/ar1qf0FRG0azm//wh7DInjjk4fVF/TgvPSxgAVMlvL1X7qpl4LjP jNljyFnXfaqfjY0QHr9HoUFmF3qmbssLu0+R3LNldQAH12WwydUd1i+bXH8c6HW6Z8Sp nAgPimtpWOtjL7hMV1vaKa1ov4B4zyPe50C1IOtrKwJ6fYMt/c60xAuQmSat1Zk3dJjV 6S+DeJI6WFO6sPhuJ6GkzzobaxNMyI7Dkpp1T1LpF9bv/NawQbFe3zMLWyR96nbCa8Q5 2sVA== X-Gm-Message-State: AFeK/H3zpsKXtVOOQ6lKVJ7Qfex4+ALcorO6oNa8H+s/xROJP9LGatZT61HW+J9P7Xx8sg== X-Received: by 10.28.127.13 with SMTP id a13mr9411624wmd.96.1489675169674; Thu, 16 Mar 2017 07:39:29 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id x193sm4544916wme.23.2017.03.16.07.39.28 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 16 Mar 2017 07:39:29 -0700 (PDT) From: Yao Qi To: Jiong Wang Cc: Andreas Arnez , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word References: Date: Thu, 16 Mar 2017 14:39:00 -0000 In-Reply-To: (Jiong Wang's message of "Thu, 16 Mar 2017 10:44:34 +0000") Message-ID: <86d1dhmgkg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00260.txt.bz2 Jiong Wang writes: > I am seeing the following build failure on my local AArch32 native build: > > ...binutils-gdb/gdb/inf-ptrace.c:473:65: error: no matching function > for call to 'min(unsigned int, ULONGEST)' > > There are a few ways to fix this, this patch simply change the type of > "skip" from "unsigned int" to "ULONGEST" so operands for std::min can > have the same type. > > OK for master? > Yes, pleas apply, a nit below, > gdb/ > 2017-03-16 Jiong Wang > > * inf-ptrace.c (inf_ptrace_peek_poke): Change the type to "ULONGE= ST" for This line is too long. The max line length of ChangeLog is 74. > "skip". --=20 Yao (=E9=BD=90=E5=B0=A7)