From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30862 invoked by alias); 14 Mar 2017 18:24:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30843 invoked by uid 89); 14 Mar 2017 18:24:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*f:sk:6640b18, H*i:sk:6640b18 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Mar 2017 18:24:51 +0000 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v2EIIkwT048971 for ; Tue, 14 Mar 2017 14:24:51 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 296nfx0xcd-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 14 Mar 2017 14:24:50 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Mar 2017 18:24:48 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 14 Mar 2017 18:24:46 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v2EIOkh625886812; Tue, 14 Mar 2017 18:24:46 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 591DE4203F; Tue, 14 Mar 2017 18:24:28 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2EA9042045; Tue, 14 Mar 2017 18:24:28 +0000 (GMT) Received: from oc1027705133.ibm.com (unknown [9.152.212.162]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 14 Mar 2017 18:24:28 +0000 (GMT) From: Andreas Arnez To: Pedro Alves Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v2] inf-ptrace: Do not stop memory transfers after a single word References: <6640b187-bad5-a584-73b0-4e151a85fc3c@redhat.com> Date: Tue, 14 Mar 2017 18:24:00 -0000 In-Reply-To: <6640b187-bad5-a584-73b0-4e151a85fc3c@redhat.com> (Pedro Alves's message of "Tue, 14 Mar 2017 17:13:53 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17031418-0040-0000-0000-00000360F72C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17031418-0041-0000-0000-00001F42EA33 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-14_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703140141 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00245.txt.bz2 On Tue, Mar 14 2017, Pedro Alves wrote: > On 03/14/2017 03:44 PM, Andreas Arnez wrote: >> Version 1 is here: >> >> https://sourceware.org/ml/gdb-patches/2017-03/msg00043.html >> >> Changes from version 1: >> >> * "unsigned" -> "unsigned int" >> >> * Compare pointers with NULL explicitly. > > Pedantically, it should be "if (errno != 0)" and > "*xfered_len != 0 ? ...." as well. OK, changed those as well. > >> >> * Move the ptrace peek/poke loop to a separate routine for better >> readability. >> >> OK to apply? > > LGTM. Thanks! I noticed that the commit message is now slightly wrong, because GDB now *does* exploit writing to /proc//mem. Fixed the commit message accordingly. Pushed with the above changes. -- Andreas