From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Hui Zhu <teawater@gmail.com>, Michael Snyder <msnyder@vmware.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case.
Date: Tue, 08 Mar 2011 17:20:00 -0000 [thread overview]
Message-ID: <m362rtilga.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110308043242.GI30306@adacore.com> (Joel Brobecker's message of "Tue, 8 Mar 2011 08:32:42 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I'm going to be a little extremist, and I don't really mean what
Joel> I am about to ask, but: If the author of the code does not understand
Joel> the code, and no other maintainer is able to review associated patches,
Joel> is it time to remove that code?
I think the code is understandable, just not as clear as I might like.
In my case the issue here is not understandability but rather laziness:
looking up all the details is a pain, surely somebody else will look at
it sooner than I will, etc.
In sum I think that removing it is somewhat too extremist :)
Tom
prev parent reply other threads:[~2011-03-08 17:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 22:34 Michael Snyder
2011-03-02 22:47 ` Mark Kettenis
2011-03-04 19:05 ` Michael Snyder
2011-03-07 9:01 ` Hui Zhu
2011-03-07 19:06 ` Michael Snyder
2011-03-08 4:35 ` Hui Zhu
2011-03-08 4:54 ` Joel Brobecker
2011-03-08 4:58 ` Hui Zhu
2011-03-08 18:50 ` Michael Snyder
2011-03-08 17:20 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m362rtilga.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox