From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9386 invoked by alias); 8 Mar 2011 17:14:52 -0000 Received: (qmail 9371 invoked by uid 22791); 8 Mar 2011 17:14:50 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 17:14:40 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p28HEGiF014735 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Mar 2011 12:14:16 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p28HEEfX026159; Tue, 8 Mar 2011 12:14:14 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p28HEDL2008664; Tue, 8 Mar 2011 12:14:14 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6FA2B3782A7; Tue, 8 Mar 2011 10:14:13 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: Hui Zhu , Michael Snyder , "gdb-patches\@sourceware.org" Subject: Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case. References: <4D6EC5ED.3070307@vmware.com> <4D7137F6.4020000@vmware.com> <4D7527EE.9020204@vmware.com> <20110308043242.GI30306@adacore.com> Date: Tue, 08 Mar 2011 17:20:00 -0000 In-Reply-To: <20110308043242.GI30306@adacore.com> (Joel Brobecker's message of "Tue, 8 Mar 2011 08:32:42 +0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00543.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I'm going to be a little extremist, and I don't really mean what Joel> I am about to ask, but: If the author of the code does not understand Joel> the code, and no other maintainer is able to review associated patches, Joel> is it time to remove that code? I think the code is understandable, just not as clear as I might like. In my case the issue here is not understandability but rather laziness: looking up all the details is a pain, surely somebody else will look at it sooner than I will, etc. In sum I think that removing it is somewhat too extremist :) Tom