Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@vmware.com
Cc: gdb-patches@sourceware.org, teawater@gmail.com
Subject: Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case.
Date: Wed, 02 Mar 2011 22:47:00 -0000	[thread overview]
Message-ID: <201103022247.p22Ml7JT009485@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4D6EC5ED.3070307@vmware.com> (message from Michael Snyder on	Wed, 02 Mar 2011 14:34:21 -0800)

> Date: Wed, 02 Mar 2011 14:34:21 -0800
> From: Michael Snyder <msnyder@vmware.com>
> 
> Hui, is this right?

Michael, if it is correct, please document these with a simple

/* FALLTHROUGH */

instead of inventing your own all caps annotations.

Thanks,

Mark

> 2011-03-02  Michael Snyder  <msnyder@vmware.com>
> 
> 	* i386-tdep.c (i386_process_record): Document fall through.
> 
> Index: i386-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.324
> diff -u -p -u -p -r1.324 i386-tdep.c
> --- i386-tdep.c	8 Feb 2011 14:01:47 -0000	1.324
> +++ i386-tdep.c	2 Mar 2011 22:31:15 -0000
> @@ -4543,6 +4543,7 @@ Do you want to stop the program?"),
>  	  ir.addr -= 1;
>  	  goto no_support;
>  	}
> +      /* ELSE FALL THROUGH */
>      case 0x0fb2:    /* lss Gv */
>      case 0x0fb4:    /* lfs Gv */
>      case 0x0fb5:    /* lgs Gv */
> 
> --------------040400010108040302090109--
> 


  reply	other threads:[~2011-03-02 22:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02 22:34 Michael Snyder
2011-03-02 22:47 ` Mark Kettenis [this message]
2011-03-04 19:05 ` Michael Snyder
2011-03-07  9:01   ` Hui Zhu
2011-03-07 19:06     ` Michael Snyder
2011-03-08  4:35       ` Hui Zhu
2011-03-08  4:54         ` Joel Brobecker
2011-03-08  4:58           ` Hui Zhu
2011-03-08 18:50             ` Michael Snyder
2011-03-08 17:20           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103022247.p22Ml7JT009485@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox