From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79023-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6899 invoked by alias); 2 Mar 2011 22:47:26 -0000
Received: (qmail 6889 invoked by uid 22791); 2 Mar 2011 22:47:26 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 22:47:19 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p22Ml8Ih000956;	Wed, 2 Mar 2011 23:47:08 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p22Ml7JT009485;	Wed, 2 Mar 2011 23:47:07 +0100 (CET)
Date: Wed, 02 Mar 2011 22:47:00 -0000
Message-Id: <201103022247.p22Ml7JT009485@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@vmware.com
CC: gdb-patches@sourceware.org, teawater@gmail.com
In-reply-to: <4D6EC5ED.3070307@vmware.com> (message from Michael Snyder on	Wed, 02 Mar 2011 14:34:21 -0800)
Subject: Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case.
References:  <4D6EC5ED.3070307@vmware.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00136.txt.bz2

> Date: Wed, 02 Mar 2011 14:34:21 -0800
> From: Michael Snyder <msnyder@vmware.com>
> 
> Hui, is this right?

Michael, if it is correct, please document these with a simple

/* FALLTHROUGH */

instead of inventing your own all caps annotations.

Thanks,

Mark

> 2011-03-02  Michael Snyder  <msnyder@vmware.com>
> 
> 	* i386-tdep.c (i386_process_record): Document fall through.
> 
> Index: i386-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.324
> diff -u -p -u -p -r1.324 i386-tdep.c
> --- i386-tdep.c	8 Feb 2011 14:01:47 -0000	1.324
> +++ i386-tdep.c	2 Mar 2011 22:31:15 -0000
> @@ -4543,6 +4543,7 @@ Do you want to stop the program?"),
>  	  ir.addr -= 1;
>  	  goto no_support;
>  	}
> +      /* ELSE FALL THROUGH */
>      case 0x0fb2:    /* lss Gv */
>      case 0x0fb4:    /* lfs Gv */
>      case 0x0fb5:    /* lgs Gv */
> 
> --------------040400010108040302090109--
>