From: Michael Snyder <msnyder@vmware.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case.
Date: Tue, 08 Mar 2011 18:50:00 -0000 [thread overview]
Message-ID: <4D7679AB.2040302@vmware.com> (raw)
In-Reply-To: <AANLkTi=My2N-OYrWYhuEXd7utF2y1Y0HPuo4mFC7z401@mail.gmail.com>
Hui Zhu wrote:
> And about the code:
> case 0xc4: /* les Gv */
> case 0xc5: /* lds Gv */
> if (ir.regmap[X86_RECORD_R8_REGNUM])
> {
> ir.addr -= 1;
> goto no_support;
> }
>
> switch (opcode)
> {
> case 0xc4: /* les Gv */
> regnum = X86_RECORD_ES_REGNUM;
> break;
> case 0xc5: /* lds Gv */
> regnum = X86_RECORD_DS_REGNUM;
> break;
>
> I check my code didn't very clear. This part is a "/* ELSE FALL THROUGH */".
Thank you. So committed.
next prev parent reply other threads:[~2011-03-08 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 22:34 Michael Snyder
2011-03-02 22:47 ` Mark Kettenis
2011-03-04 19:05 ` Michael Snyder
2011-03-07 9:01 ` Hui Zhu
2011-03-07 19:06 ` Michael Snyder
2011-03-08 4:35 ` Hui Zhu
2011-03-08 4:54 ` Joel Brobecker
2011-03-08 4:58 ` Hui Zhu
2011-03-08 18:50 ` Michael Snyder [this message]
2011-03-08 17:20 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7679AB.2040302@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox