From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79443-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8312 invoked by alias); 8 Mar 2011 18:47:14 -0000
Received: (qmail 8303 invoked by uid 22791); 8 Mar 2011 18:47:13 -0000
X-SWARE-Spam-Status: No, hits=-5.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 18:47:09 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 67B20D007;	Tue,  8 Mar 2011 10:47:08 -0800 (PST)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost4.vmware.com (Postfix) with ESMTP id 5DEFDC9FF5;	Tue,  8 Mar 2011 10:47:08 -0800 (PST)
Message-ID: <4D7679AB.2040302@vmware.com>
Date: Tue, 08 Mar 2011 18:50:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20101201)
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: Joel Brobecker <brobecker@adacore.com>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case.
References: <4D6EC5ED.3070307@vmware.com> <4D7137F6.4020000@vmware.com> <AANLkTikccSXC_JargcKh56Bue_++805pptaZTLcab+cU@mail.gmail.com> <4D7527EE.9020204@vmware.com> <AANLkTinNQXQWRvk1G8fiXGt1tJXwOGc=BzCDmv_fdf=r@mail.gmail.com> <20110308043242.GI30306@adacore.com> <AANLkTi=My2N-OYrWYhuEXd7utF2y1Y0HPuo4mFC7z401@mail.gmail.com>
In-Reply-To: <AANLkTi=My2N-OYrWYhuEXd7utF2y1Y0HPuo4mFC7z401@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00556.txt.bz2

Hui Zhu wrote:
> And about the code:
>     case 0xc4:    /* les Gv */
>     case 0xc5:    /* lds Gv */
>       if (ir.regmap[X86_RECORD_R8_REGNUM])
>         {
> 	  ir.addr -= 1;
> 	  goto no_support;
> 	}
> 
>       switch (opcode)
> 	{
> 	case 0xc4:    /* les Gv */
> 	  regnum = X86_RECORD_ES_REGNUM;
> 	  break;
> 	case 0xc5:    /* lds Gv */
> 	  regnum = X86_RECORD_DS_REGNUM;
> 	  break;
> 
> I check my code didn't very clear.  This part is a "/* ELSE FALL THROUGH */".


Thank you.  So committed.