Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: gdb-patches@sources.redhat.com
Subject: Re: PR threads/2015: Fix adjust_pc_after_break for thread debugging
Date: Tue, 27 Sep 2005 22:57:00 -0000	[thread overview]
Message-ID: <jefyrqglv7.fsf@sykes.suse.de> (raw)
In-Reply-To: <20050927221952.GA22753@nevyn.them.org> (Daniel Jacobowitz's message of "Tue, 27 Sep 2005 18:19:52 -0400")

Daniel Jacobowitz <drow@false.org> writes:

> Which test failures are these?  i.e. why doesn't anyone else see this
> when they run the testsuite?

I've somehow lost the log files and had to rerun the testsuite, and now I
no longer see any difference in the test results.

> Offhand I'd be suspicious that this helped - some other thread probably
> needs its PC adjusted and now may not be.

The patch will never result in less adjustments, because the other arm of
the conditional will do the adjustment anyway if a breakpoint exists at
the current PC.  Note that prev_pc is also part of the thread context and
may be wrong for the current thread as well.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  parent reply	other threads:[~2005-09-27 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-27 22:10 Andreas Schwab
2005-09-27 22:18 ` Mark Kettenis
2005-09-27 22:36   ` Andreas Schwab
2005-09-27 22:20 ` Daniel Jacobowitz
2005-09-27 22:24   ` Daniel Jacobowitz
2005-09-27 22:57   ` Andreas Schwab [this message]
2005-09-28 14:59     ` Daniel Jacobowitz
2005-09-28 15:47       ` Andreas Schwab
2005-09-28 15:51         ` Daniel Jacobowitz
2005-09-28 18:16 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jefyrqglv7.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox