From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: schwab@suse.de
Cc: gdb-patches@sources.redhat.com
Subject: Re: PR threads/2015: Fix adjust_pc_after_break for thread debugging
Date: Tue, 27 Sep 2005 22:18:00 -0000 [thread overview]
Message-ID: <200509272218.j8RMIhj1022989@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <jevf0mgo1h.fsf@sykes.suse.de> (message from Andreas Schwab on Wed, 28 Sep 2005 00:10:18 +0200)
> X-From_: gdb-patches-return-40942-m.m.kettenis=alumnus.utwente.nl@sources.redhat.com Wed Sep 28 00:10:41 2005
> From: Andreas Schwab <schwab@suse.de>
> Date: Wed, 28 Sep 2005 00:10:18 +0200
>
> adjust_pc_after_break is doing the wrong thing during thread debugging
> when the current thread is different from the thread when the debuggee was
> stopped last. The problem is that it calls currently_stepping, which
> accesses global variables that are part of the thread context. But the
> context switch will only happen much later on. The proposed fix will skip
> the call when the current infrun context does not match the thread to be
> examined. This has been tested on x86_64-suse-linux and fixes 32
> testcases without any regressions.
I'd really like to see this tested on some more systems though,
especially on systems where adjust_pc_after_break is a no-op and
systems with software single-step.
I can run a few tests later this week if you want.
Mark
next prev parent reply other threads:[~2005-09-27 22:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 22:10 Andreas Schwab
2005-09-27 22:18 ` Mark Kettenis [this message]
2005-09-27 22:36 ` Andreas Schwab
2005-09-27 22:20 ` Daniel Jacobowitz
2005-09-27 22:24 ` Daniel Jacobowitz
2005-09-27 22:57 ` Andreas Schwab
2005-09-28 14:59 ` Daniel Jacobowitz
2005-09-28 15:47 ` Andreas Schwab
2005-09-28 15:51 ` Daniel Jacobowitz
2005-09-28 18:16 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509272218.j8RMIhj1022989@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox