From: Andreas Schwab <schwab@suse.de>
To: gdb-patches@sources.redhat.com
Subject: PR threads/2015: Fix adjust_pc_after_break for thread debugging
Date: Tue, 27 Sep 2005 22:10:00 -0000 [thread overview]
Message-ID: <jevf0mgo1h.fsf@sykes.suse.de> (raw)
adjust_pc_after_break is doing the wrong thing during thread debugging
when the current thread is different from the thread when the debuggee was
stopped last. The problem is that it calls currently_stepping, which
accesses global variables that are part of the thread context. But the
context switch will only happen much later on. The proposed fix will skip
the call when the current infrun context does not match the thread to be
examined. This has been tested on x86_64-suse-linux and fixes 32
testcases without any regressions.
Andreas.
2005-09-28 Andreas Schwab <schwab@suse.de>
PR threads/2015
* infrun.c (adjust_pc_after_break): Don't use the state from a
non-matching thread context.
--- gdb/infrun.c 01 Aug 2005 11:52:13 +0200 1.203
+++ gdb/infrun.c 28 Sep 2005 00:03:47 +0200
@@ -1200,8 +1200,12 @@ adjust_pc_after_break (struct execution_
/* When using hardware single-step, a SIGTRAP is reported for
both a completed single-step and a software breakpoint. Need
to differentiate between the two as the latter needs
- adjusting but the former does not. */
- if (currently_stepping (ecs))
+ adjusting but the former does not.
+
+ When the thread to be examined does not match the current thread
+ context we can't use currently_stepping, so assume no
+ single-stepping in this case. */
+ if (ptid_equal (ecs->ptid, inferior_ptid) && currently_stepping (ecs))
{
if (prev_pc == breakpoint_pc
&& software_breakpoint_inserted_here_p (breakpoint_pc))
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next reply other threads:[~2005-09-27 22:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-27 22:10 Andreas Schwab [this message]
2005-09-27 22:18 ` Mark Kettenis
2005-09-27 22:36 ` Andreas Schwab
2005-09-27 22:20 ` Daniel Jacobowitz
2005-09-27 22:24 ` Daniel Jacobowitz
2005-09-27 22:57 ` Andreas Schwab
2005-09-28 14:59 ` Daniel Jacobowitz
2005-09-28 15:47 ` Andreas Schwab
2005-09-28 15:51 ` Daniel Jacobowitz
2005-09-28 18:16 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jevf0mgo1h.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox