From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5607 invoked by alias); 27 Sep 2005 22:18:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5576 invoked by uid 22791); 27 Sep 2005 22:18:46 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 27 Sep 2005 22:18:46 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id j8RMIhLu017056; Wed, 28 Sep 2005 00:18:43 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j8RMIhKv014079; Wed, 28 Sep 2005 00:18:43 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j8RMIhj1022989; Wed, 28 Sep 2005 00:18:43 +0200 (CEST) Date: Tue, 27 Sep 2005 22:18:00 -0000 Message-Id: <200509272218.j8RMIhj1022989@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: schwab@suse.de CC: gdb-patches@sources.redhat.com In-reply-to: (message from Andreas Schwab on Wed, 28 Sep 2005 00:10:18 +0200) Subject: Re: PR threads/2015: Fix adjust_pc_after_break for thread debugging References: X-SW-Source: 2005-09/txt/msg00257.txt.bz2 > X-From_: gdb-patches-return-40942-m.m.kettenis=alumnus.utwente.nl@sources.redhat.com Wed Sep 28 00:10:41 2005 > From: Andreas Schwab > Date: Wed, 28 Sep 2005 00:10:18 +0200 > > adjust_pc_after_break is doing the wrong thing during thread debugging > when the current thread is different from the thread when the debuggee was > stopped last. The problem is that it calls currently_stepping, which > accesses global variables that are part of the thread context. But the > context switch will only happen much later on. The proposed fix will skip > the call when the current infrun context does not match the thread to be > examined. This has been tested on x86_64-suse-linux and fixes 32 > testcases without any regressions. I'd really like to see this tested on some more systems though, especially on systems where adjust_pc_after_break is a no-op and systems with software single-step. I can run a few tests later this week if you want. Mark