From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26442 invoked by alias); 27 Sep 2005 22:57:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26420 invoked by uid 22791); 27 Sep 2005 22:57:19 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 27 Sep 2005 22:57:19 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 374CA1D991 for ; Wed, 28 Sep 2005 00:57:17 +0200 (CEST) From: Andreas Schwab To: gdb-patches@sources.redhat.com Subject: Re: PR threads/2015: Fix adjust_pc_after_break for thread debugging References: <20050927221952.GA22753@nevyn.them.org> X-Yow: On SECOND thought, maybe I'll heat up some BAKED BEANS and watch REGIS PHILBIN.. It's GREAT to be ALIVE!! Date: Tue, 27 Sep 2005 22:57:00 -0000 In-Reply-To: <20050927221952.GA22753@nevyn.them.org> (Daniel Jacobowitz's message of "Tue, 27 Sep 2005 18:19:52 -0400") Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2005-09/txt/msg00262.txt.bz2 Daniel Jacobowitz writes: > Which test failures are these? i.e. why doesn't anyone else see this > when they run the testsuite? I've somehow lost the log files and had to rerun the testsuite, and now I no longer see any difference in the test results. > Offhand I'd be suspicious that this helped - some other thread probably > needs its PC adjusted and now may not be. The patch will never result in less adjustments, because the other arm of the conditional will do the adjustment anyway if a breakpoint exists at the current PC. Note that prev_pc is also part of the thread context and may be wrong for the current thread as well. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."