Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Hannes Domani <ssbssa@yahoo.de>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight
Date: Fri, 15 Mar 2019 16:45:00 -0000	[thread overview]
Message-ID: <eb04398e-6a0e-c87f-9851-963074f4f29d@redhat.com> (raw)
In-Reply-To: <186859064.9289078.1552667917410@mail.yahoo.com>

On 03/15/2019 04:38 PM, Hannes Domani via gdb-patches wrote:
> Am Donnerstag, 14. März 2019, 18:47:56 MEZ hat Pedro Alves <palves@redhat.com> Folgendes geschrieben: 
> 
>> WDYT?
> 
> The result looks very nice.
> 
> 
>> +/* If true, we're highlighting the current source line in reverse
>> +  video mode.  */
>> +static bool reverse_mode_p = true;
> 
> Shouldn't this variable be initialized to false?
> Weird things happen on my end with true (sometimes the cmd window contents are reversed).
> 

Wow, of course.  I have no idea how I missed that.

> 
> Also, I had to add the following to make it work on windows
> (but beware, I'm using pdcurses, not ncurses, and I don't know if ncurses
> for windows needs this as well):

Thanks, but can you explain it?  It is not obvious to me.

Thanks,
Pedro Alves


  reply	other threads:[~2019-03-15 16:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 17:47 Pedro Alves
2019-03-14 19:55 ` John Baldwin
2019-03-14 20:10   ` Pedro Alves
2019-03-15 16:39 ` Hannes Domani via gdb-patches
2019-03-15 16:45   ` Pedro Alves [this message]
2019-03-17 16:07   ` Eli Zaretskii
2019-03-17 16:46     ` Hannes Domani via gdb-patches
2019-03-17 16:53       ` Eli Zaretskii
2019-03-18 14:45       ` Pedro Alves
2019-03-15 21:41 ` Tom Tromey
     [not found] <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com>
2019-03-14 19:49 ` Eli Zaretskii
2019-03-14 20:14   ` Pedro Alves
2019-03-17 15:57 ` Eli Zaretskii
2019-03-18 14:42   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb04398e-6a0e-c87f-9851-963074f4f29d@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ssbssa@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox