From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40106 invoked by alias); 15 Mar 2019 16:45:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39135 invoked by uid 89); 15 Mar 2019 16:45:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=video, explain, HContent-Transfer-Encoding:8bit X-HELO: mail-wm1-f49.google.com Received: from mail-wm1-f49.google.com (HELO mail-wm1-f49.google.com) (209.85.128.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Mar 2019 16:45:26 +0000 Received: by mail-wm1-f49.google.com with SMTP id t124so6663794wma.4 for ; Fri, 15 Mar 2019 09:45:26 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id c10sm2824116wrr.1.2019.03.15.09.45.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 09:45:23 -0700 (PDT) Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight To: Hannes Domani , GDB Patches References: <6ada07d6-ff84-e215-19ff-0a17563390c6@redhat.com> <186859064.9289078.1552667917410@mail.yahoo.com> From: Pedro Alves Message-ID: Date: Fri, 15 Mar 2019 16:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <186859064.9289078.1552667917410@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-03/txt/msg00319.txt.bz2 On 03/15/2019 04:38 PM, Hannes Domani via gdb-patches wrote: > Am Donnerstag, 14. März 2019, 18:47:56 MEZ hat Pedro Alves Folgendes geschrieben: > >> WDYT? > > The result looks very nice. > > >> +/* If true, we're highlighting the current source line in reverse >> +  video mode.  */ >> +static bool reverse_mode_p = true; > > Shouldn't this variable be initialized to false? > Weird things happen on my end with true (sometimes the cmd window contents are reversed). > Wow, of course. I have no idea how I missed that. > > Also, I had to add the following to make it work on windows > (but beware, I'm using pdcurses, not ncurses, and I don't know if ncurses > for windows needs this as well): Thanks, but can you explain it? It is not obvious to me. Thanks, Pedro Alves