Re: [PATCH] Improve/fix the TUI's current source line highlight

[Pedro Alves <palves@redhat.com>]

-- 
Thanks,
Pedro Alves
On 03/14/2019 06:32 PM, Eli Zaretskii wrote:
>> From: Pedro Alves <palves@redhat.com>
>> Date: Thu, 14 Mar 2019 17:35:57 +0000
>>
>> With styling enabled, I think the way we display the TUI's
>> highlighted/current line is very ugly and distracting.  At least,
>> I can't seem to get used to it.  The problem in my view is that we
>> reverse foreground/background in colored text as well, leading to
>> a fuzzy rainbow of colors.
> 
> Yes, I've seen this is as well, and it caused me to raise a brow ;-)
> 
>> WDYT?  
> 
> I like the change, thanks.
> 
>> Eli, could you try this on Windows, see if it behaves as intended there?
> 
> I will, but did your changes also handle the problems with
> highlighting lines longer than the window-width?  

It does not, that's an independent issue.

> I posted a patch for
> that in https://www.sourceware.org/ml/gdb-patches/2019-03/msg00271.html.
> If your patches don't handle that problem, we will need to merge these
> two together.
Let me go take a look at it.  I admit to being confused with all those
patches under the same subject.

Thanks,
Pedro Alves