From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight
Date: Thu, 14 Mar 2019 19:49:00 -0000 [thread overview]
Message-ID: <83mulx1f3j.fsf@gnu.org> (raw)
In-Reply-To: <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com> (message from Pedro Alves on Thu, 14 Mar 2019 17:35:57 +0000)
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 14 Mar 2019 17:35:57 +0000
>
> With styling enabled, I think the way we display the TUI's
> highlighted/current line is very ugly and distracting. At least,
> I can't seem to get used to it. The problem in my view is that we
> reverse foreground/background in colored text as well, leading to
> a fuzzy rainbow of colors.
Yes, I've seen this is as well, and it caused me to raise a brow ;-)
> WDYT?
I like the change, thanks.
> Eli, could you try this on Windows, see if it behaves as intended there?
I will, but did your changes also handle the problems with
highlighting lines longer than the window-width? I posted a patch for
that in https://www.sourceware.org/ml/gdb-patches/2019-03/msg00271.html.
If your patches don't handle that problem, we will need to merge these
two together.
next parent reply other threads:[~2019-03-14 19:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com>
2019-03-14 19:49 ` Eli Zaretskii [this message]
2019-03-14 20:14 ` Pedro Alves
2019-03-17 15:57 ` Eli Zaretskii
2019-03-18 14:42 ` Pedro Alves
2019-03-14 17:47 Pedro Alves
2019-03-14 19:55 ` John Baldwin
2019-03-14 20:10 ` Pedro Alves
2019-03-15 16:39 ` Hannes Domani via gdb-patches
2019-03-15 16:45 ` Pedro Alves
2019-03-17 16:07 ` Eli Zaretskii
2019-03-17 16:46 ` Hannes Domani via gdb-patches
2019-03-17 16:53 ` Eli Zaretskii
2019-03-18 14:45 ` Pedro Alves
2019-03-15 21:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mulx1f3j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox