From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight
Date: Fri, 15 Mar 2019 21:41:00 -0000 [thread overview]
Message-ID: <87wokz6cjh.fsf@tromey.com> (raw)
In-Reply-To: <6ada07d6-ff84-e215-19ff-0a17563390c6@redhat.com> (Pedro Alves's message of "Thu, 14 Mar 2019 17:47:33 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> This patch changes that to something that I find much more sensible --
Pedro> only reverse the default foreground/background colors, leave styled
Pedro> text colors alone. If the foreground color is not the default (because the
Pedro> text was styled), leave the foreground color as is.
Pedro> I've attached screenshots of before/after patch
Finally we need screenshots for gdb! I thought the day would never
come.
Pedro> Note: The new ui_file_style::set_fg method isn't called set_foreground
Pedro> instead, because set_foreground is a macro in /usr/lib/term.h (ncurses).
Pedro> WDYT?
Looks much better, please check this in.
Tom
next prev parent reply other threads:[~2019-03-15 21:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 17:47 Pedro Alves
2019-03-14 19:55 ` John Baldwin
2019-03-14 20:10 ` Pedro Alves
2019-03-15 16:39 ` Hannes Domani via gdb-patches
2019-03-15 16:45 ` Pedro Alves
2019-03-17 16:07 ` Eli Zaretskii
2019-03-17 16:46 ` Hannes Domani via gdb-patches
2019-03-17 16:53 ` Eli Zaretskii
2019-03-18 14:45 ` Pedro Alves
2019-03-15 21:41 ` Tom Tromey [this message]
[not found] <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com>
2019-03-14 19:49 ` Eli Zaretskii
2019-03-14 20:14 ` Pedro Alves
2019-03-17 15:57 ` Eli Zaretskii
2019-03-18 14:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wokz6cjh.fsf@tromey.com \
--to=tom@tromey.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox