From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17777 invoked by alias); 15 Mar 2019 21:41:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17764 invoked by uid 89); 15 Mar 2019 21:41:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=screenshots, termh, set_fg, set_foreground X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Mar 2019 21:41:25 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 2C46ABBB5D for ; Fri, 15 Mar 2019 16:41:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4uZvh9Hmo2PzO4uZvhVRdh; Fri, 15 Mar 2019 16:41:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XFlbT5DdmxPV98M/dLsCQRixKuyRKZ/K03vTgDn0qUc=; b=C5QJdXdPEHGON3D6FpHk55JolK 4XsUa277LrBMILl4rGuequLRAGL1FJSqeCK18ReIYnEO9LDG2tPnxSgXPA3/rfHL9S5IhL1BIO4bR XL0qjQv/08kI1bRkKAS5Maxfj; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:52464 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h4uZv-002N2U-FL; Fri, 15 Mar 2019 16:41:23 -0500 From: Tom Tromey To: Pedro Alves Cc: GDB Patches , Tom Tromey , Eli Zaretskii Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight References: <6ada07d6-ff84-e215-19ff-0a17563390c6@redhat.com> Date: Fri, 15 Mar 2019 21:41:00 -0000 In-Reply-To: <6ada07d6-ff84-e215-19ff-0a17563390c6@redhat.com> (Pedro Alves's message of "Thu, 14 Mar 2019 17:47:33 +0000") Message-ID: <87wokz6cjh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00322.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This patch changes that to something that I find much more sensible -- Pedro> only reverse the default foreground/background colors, leave styled Pedro> text colors alone. If the foreground color is not the default (because the Pedro> text was styled), leave the foreground color as is. Pedro> I've attached screenshots of before/after patch Finally we need screenshots for gdb! I thought the day would never come. Pedro> Note: The new ui_file_style::set_fg method isn't called set_foreground Pedro> instead, because set_foreground is a macro in /usr/lib/term.h (ncurses). Pedro> WDYT? Looks much better, please check this in. Tom