From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75165 invoked by alias); 14 Mar 2019 19:49:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75152 invoked by uid 89); 14 Mar 2019 19:49:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=windowwidth, window-width, 201903 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Mar 2019 19:49:52 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4WMR-0001S6-7E; Thu, 14 Mar 2019 15:49:51 -0400 Received: from [176.228.60.248] (port=3233 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h4VAQ-00024J-3O; Thu, 14 Mar 2019 14:33:24 -0400 Date: Thu, 14 Mar 2019 19:49:00 -0000 Message-Id: <83mulx1f3j.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org, tom@tromey.com In-reply-to: <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com> (message from Pedro Alves on Thu, 14 Mar 2019 17:35:57 +0000) Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight References: <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00298.txt.bz2 > From: Pedro Alves > Date: Thu, 14 Mar 2019 17:35:57 +0000 > > With styling enabled, I think the way we display the TUI's > highlighted/current line is very ugly and distracting. At least, > I can't seem to get used to it. The problem in my view is that we > reverse foreground/background in colored text as well, leading to > a fuzzy rainbow of colors. Yes, I've seen this is as well, and it caused me to raise a brow ;-) > WDYT? I like the change, thanks. > Eli, could you try this on Windows, see if it behaves as intended there? I will, but did your changes also handle the problems with highlighting lines longer than the window-width? I posted a patch for that in https://www.sourceware.org/ml/gdb-patches/2019-03/msg00271.html. If your patches don't handle that problem, we will need to merge these two together.