From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27834 invoked by alias); 14 Mar 2019 20:14:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27823 invoked by uid 89); 14 Mar 2019 20:14:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1178, 201903 X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Mar 2019 20:14:28 +0000 Received: by mail-wr1-f68.google.com with SMTP id y13so2695285wrd.3 for ; Thu, 14 Mar 2019 13:14:28 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id l3sm18122428wrt.62.2019.03.14.13.14.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 13:14:25 -0700 (PDT) Subject: Re: [PATCH] Improve/fix the TUI's current source line highlight To: Eli Zaretskii References: <24ebd86d-ac47-bc8d-042a-e29ae2b4301e@redhat.com> <83mulx1f3j.fsf@gnu.org> Cc: gdb-patches@sourceware.org, tom@tromey.com From: Pedro Alves Message-ID: <3b8bceed-62d6-ec10-30b4-d8288cff7178@redhat.com> Date: Thu, 14 Mar 2019 20:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83mulx1f3j.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00301.txt.bz2 -- Thanks, Pedro Alves On 03/14/2019 06:32 PM, Eli Zaretskii wrote: >> From: Pedro Alves >> Date: Thu, 14 Mar 2019 17:35:57 +0000 >> >> With styling enabled, I think the way we display the TUI's >> highlighted/current line is very ugly and distracting. At least, >> I can't seem to get used to it. The problem in my view is that we >> reverse foreground/background in colored text as well, leading to >> a fuzzy rainbow of colors. > > Yes, I've seen this is as well, and it caused me to raise a brow ;-) > >> WDYT? > > I like the change, thanks. > >> Eli, could you try this on Windows, see if it behaves as intended there? > > I will, but did your changes also handle the problems with > highlighting lines longer than the window-width? It does not, that's an independent issue. > I posted a patch for > that in https://www.sourceware.org/ml/gdb-patches/2019-03/msg00271.html. > If your patches don't handle that problem, we will need to merge these > two together. Let me go take a look at it. I admit to being confused with all those patches under the same subject. Thanks, Pedro Alves