remove warnings in sim/arm

remove warnings in sim/arm

[Joel Sherrill]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi,

a couple of files in arm/sim had warnings because
they did not include <string.h>.  Simple patch
to include <string.h>

Ok to commit?

2008-11-24  Joel Sherrill <joel.sherrill@oarcorp.com>

    * arminit.c, iwmmxt.c: Include <string.h> to
    eliminate warning.

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
   Support Available             (256) 722-9985



[-- Attachment #2: arm-sim.diff --]
[-- Type: text/x-patch, Size: 1053 bytes --]

? .iwmmxt.c.swp
Index: arminit.c
===================================================================
RCS file: /cvs/src/src/sim/arm/arminit.c,v
retrieving revision 1.12
diff -u -r1.12 arminit.c
--- arminit.c	12 May 2005 07:36:58 -0000	1.12
+++ arminit.c	24 Nov 2008 21:08:18 -0000
@@ -15,6 +15,8 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */
 
+#include <string.h>
+
 #include "armdefs.h"
 #include "armemu.h"
 #include "dbg_rdi.h"
Index: iwmmxt.c
===================================================================
RCS file: /cvs/src/src/sim/arm/iwmmxt.c,v
retrieving revision 1.6
diff -u -r1.6 iwmmxt.c
--- iwmmxt.c	1 Jan 2008 22:53:23 -0000	1.6
+++ iwmmxt.c	24 Nov 2008 21:08:19 -0000
@@ -15,6 +15,8 @@
     You should have received a copy of the GNU General Public License
     along with this program.  If not, see <http://www.gnu.org/licenses/>. */
 
+#include <string.h>
+
 #include "armdefs.h"
 #include "armos.h"
 #include "armemu.h"

Re: remove warnings in sim/arm

[Doug Evans]

On Mon, Nov 24, 2008 at 1:11 PM, Joel Sherrill
<joel.sherrill@oarcorp.com> wrote:
> Hi,
>
> a couple of files in arm/sim had warnings because
> they did not include <string.h>.  Simple patch
> to include <string.h>
>
> Ok to commit?
>
> 2008-11-24  Joel Sherrill <joel.sherrill@oarcorp.com>
>
>   * arminit.c, iwmmxt.c: Include <string.h> to
>   eliminate warning.

Other sims check HAVE_STRING_H, as does gdb (and STDC_HEADERS), but
there are already files in sim/arm that don't (and at some point we
should no longer need to), so this patch is fine by me.

Re: remove warnings in sim/arm

[Joel Sherrill]

Doug Evans wrote:
> On Mon, Nov 24, 2008 at 1:11 PM, Joel Sherrill
> <joel.sherrill@oarcorp.com> wrote:
>   
>> Hi,
>>
>> a couple of files in arm/sim had warnings because
>> they did not include <string.h>.  Simple patch
>> to include <string.h>
>>
>> Ok to commit?
>>
>> 2008-11-24  Joel Sherrill <joel.sherrill@oarcorp.com>
>>
>>   * arminit.c, iwmmxt.c: Include <string.h> to
>>   eliminate warning.
>>     
>
> Other sims check HAVE_STRING_H, as does gdb (and STDC_HEADERS), but
> there are already files in sim/arm that don't (and at some point we
> should no longer need to), so this patch is fine by me.
>   
Thanks.  I looked for HAVE_STRING_H in other sim/arm files
and since it wasn't there, I didn't use it.  Do you want another
patch to add HAVE_STRING_H to all the files?

I have committed this one.

--joel

Re: remove warnings in sim/arm

[Doug Evans]

On Wed, Nov 26, 2008 at 6:24 AM, Joel Sherrill
<joel.sherrill@oarcorp.com> wrote:
> Doug Evans wrote:
>>
>> On Mon, Nov 24, 2008 at 1:11 PM, Joel Sherrill
>> <joel.sherrill@oarcorp.com> wrote:
>>
>>>
>>> Hi,
>>>
>>> a couple of files in arm/sim had warnings because
>>> they did not include <string.h>.  Simple patch
>>> to include <string.h>
>>>
>>> Ok to commit?
>>>
>>> 2008-11-24  Joel Sherrill <joel.sherrill@oarcorp.com>
>>>
>>>  * arminit.c, iwmmxt.c: Include <string.h> to
>>>  eliminate warning.
>>>
>>
>> Other sims check HAVE_STRING_H, as does gdb (and STDC_HEADERS), but
>> there are already files in sim/arm that don't (and at some point we
>> should no longer need to), so this patch is fine by me.
>>
>
> Thanks.  I looked for HAVE_STRING_H in other sim/arm files
> and since it wasn't there, I didn't use it.  Do you want another
> patch to add HAVE_STRING_H to all the files?
>
> I have committed this one.

wrapper.c has been ok since at least gdb 5.2.1 so I'd say let's leave
things as they are.