From: Doug Evans <dje@google.com>
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: remove warnings in sim/arm
Date: Thu, 27 Nov 2008 14:57:00 -0000 [thread overview]
Message-ID: <e394668d0811260856j114571e8wc150e53d62661a1f@mail.gmail.com> (raw)
In-Reply-To: <492D5C13.3040603@oarcorp.com>
On Wed, Nov 26, 2008 at 6:24 AM, Joel Sherrill
<joel.sherrill@oarcorp.com> wrote:
> Doug Evans wrote:
>>
>> On Mon, Nov 24, 2008 at 1:11 PM, Joel Sherrill
>> <joel.sherrill@oarcorp.com> wrote:
>>
>>>
>>> Hi,
>>>
>>> a couple of files in arm/sim had warnings because
>>> they did not include <string.h>. Simple patch
>>> to include <string.h>
>>>
>>> Ok to commit?
>>>
>>> 2008-11-24 Joel Sherrill <joel.sherrill@oarcorp.com>
>>>
>>> * arminit.c, iwmmxt.c: Include <string.h> to
>>> eliminate warning.
>>>
>>
>> Other sims check HAVE_STRING_H, as does gdb (and STDC_HEADERS), but
>> there are already files in sim/arm that don't (and at some point we
>> should no longer need to), so this patch is fine by me.
>>
>
> Thanks. I looked for HAVE_STRING_H in other sim/arm files
> and since it wasn't there, I didn't use it. Do you want another
> patch to add HAVE_STRING_H to all the files?
>
> I have committed this one.
wrapper.c has been ok since at least gdb 5.2.1 so I'd say let's leave
things as they are.
prev parent reply other threads:[~2008-11-26 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 2:18 Joel Sherrill
2008-11-26 18:45 ` Doug Evans
2008-11-27 9:23 ` Joel Sherrill
2008-11-27 14:57 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0811260856j114571e8wc150e53d62661a1f@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=joel.sherrill@oarcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox