From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29073 invoked by alias); 26 Nov 2008 16:56:51 -0000 Received: (qmail 29060 invoked by uid 22791); 26 Nov 2008 16:56:50 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Nov 2008 16:56:15 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id mAQGuDmx005306 for ; Wed, 26 Nov 2008 08:56:13 -0800 Received: from wf-out-1314.google.com (wfc28.prod.google.com [10.142.3.28]) by wpaz21.hot.corp.google.com with ESMTP id mAQGuBBS012249 for ; Wed, 26 Nov 2008 08:56:11 -0800 Received: by wf-out-1314.google.com with SMTP id 28so556761wfc.29 for ; Wed, 26 Nov 2008 08:56:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.115.6 with SMTP id s6mr2993512rvm.235.1227718571259; Wed, 26 Nov 2008 08:56:11 -0800 (PST) In-Reply-To: <492D5C13.3040603@oarcorp.com> References: <492B1871.7080409@oarcorp.com> <492D5C13.3040603@oarcorp.com> Date: Thu, 27 Nov 2008 14:57:00 -0000 Message-ID: Subject: Re: remove warnings in sim/arm From: Doug Evans To: Joel Sherrill Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00719.txt.bz2 On Wed, Nov 26, 2008 at 6:24 AM, Joel Sherrill wrote: > Doug Evans wrote: >> >> On Mon, Nov 24, 2008 at 1:11 PM, Joel Sherrill >> wrote: >> >>> >>> Hi, >>> >>> a couple of files in arm/sim had warnings because >>> they did not include . Simple patch >>> to include >>> >>> Ok to commit? >>> >>> 2008-11-24 Joel Sherrill >>> >>> * arminit.c, iwmmxt.c: Include to >>> eliminate warning. >>> >> >> Other sims check HAVE_STRING_H, as does gdb (and STDC_HEADERS), but >> there are already files in sim/arm that don't (and at some point we >> should no longer need to), so this patch is fine by me. >> > > Thanks. I looked for HAVE_STRING_H in other sim/arm files > and since it wasn't there, I didn't use it. Do you want another > patch to add HAVE_STRING_H to all the files? > > I have committed this one. wrapper.c has been ok since at least gdb 5.2.1 so I'd say let's leave things as they are.