From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18494 invoked by alias); 26 Nov 2008 14:24:59 -0000 Received: (qmail 18486 invoked by uid 22791); 26 Nov 2008 14:24:59 -0000 X-Spam-Check-By: sourceware.org Received: from mail.oarcorp.com (HELO OARmail.OARCORP.com) (216.186.189.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Nov 2008 14:24:23 +0000 Received: from [192.168.1.3] (192.168.1.3) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.1.311.2; Wed, 26 Nov 2008 08:20:31 -0600 Message-ID: <492D5C13.3040603@oarcorp.com> Date: Thu, 27 Nov 2008 09:23:00 -0000 From: Joel Sherrill User-Agent: Thunderbird 2.0.0.18 (X11/20081119) MIME-Version: 1.0 To: Doug Evans CC: "gdb-patches@sourceware.org" Subject: Re: remove warnings in sim/arm References: <492B1871.7080409@oarcorp.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00714.txt.bz2 Doug Evans wrote: > On Mon, Nov 24, 2008 at 1:11 PM, Joel Sherrill > wrote: > >> Hi, >> >> a couple of files in arm/sim had warnings because >> they did not include . Simple patch >> to include >> >> Ok to commit? >> >> 2008-11-24 Joel Sherrill >> >> * arminit.c, iwmmxt.c: Include to >> eliminate warning. >> > > Other sims check HAVE_STRING_H, as does gdb (and STDC_HEADERS), but > there are already files in sim/arm that don't (and at some point we > should no longer need to), so this patch is fine by me. > Thanks. I looked for HAVE_STRING_H in other sim/arm files and since it wasn't there, I didn't use it. Do you want another patch to add HAVE_STRING_H to all the files? I have committed this one. --joel