From: Tom de Vries <tdevries@suse.de>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 05/11] [gdb/testsuite] Add transparent_uplevel
Date: Wed, 23 Sep 2026 21:05:12 +0200 [thread overview]
Message-ID: <e24b0016-89cc-4285-a579-bf8c4ec79569@suse.de> (raw)
In-Reply-To: <ba86a1a0-5a2e-41f8-99f0-70df46b505e8@redhat.com>
On 9/1/26 6:16 PM, Keith Seitz wrote:
>> }
>> +# Run BODY in the context of the callers caller.
>
> Typo: "caller's caller".
>
>> +#
>> +# To be used in a proc foo:
>> +# proc foo {body} {
>> +# transparent_uplevel body
>> +# }
>
> I think "body" here is missing a '$'?
Hi Keith,
thanks for the reviews.
I've fixed these two locally, and am about to push.
[ FWIW, I've debugged my LLM review setup for a bit to find out why
these, as well as the others you mentioned in this series weren't found.
That is still ongoing, but I hope that future submissions will be
better. ]
Thanks,
- Tom
next prev parent reply other threads:[~2026-09-23 19:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 13:58 [PATCH 00/11] [gdb/testsuite] Refactor exception handling Tom de Vries
2026-08-24 13:58 ` [PATCH 01/11] [gdb/testsuite] Normalize indentation in with_test_prefix Tom de Vries
2026-09-02 19:41 ` Tom Tromey
2026-09-04 9:48 ` Tom de Vries
2026-08-24 13:58 ` [PATCH 02/11] [gdb/testsuite] Fix return -level 2 bug " Tom de Vries
2026-09-02 19:46 ` Tom Tromey
2026-09-23 21:36 ` Tom de Vries
2026-09-24 14:18 ` Tom de Vries
2026-08-24 13:58 ` [PATCH 03/11] [gdb/testsuite] Simplify foreach_with_prefix Tom de Vries
2026-09-24 14:10 ` Tom de Vries
2026-08-24 13:58 ` [PATCH 04/11] [gdb/testsuite] Refactor exception handling in foreach_with_prefix Tom de Vries
2026-08-24 13:58 ` [PATCH 05/11] [gdb/testsuite] Add transparent_uplevel Tom de Vries
2026-09-01 16:16 ` Keith Seitz
2026-09-23 19:05 ` Tom de Vries [this message]
2026-08-24 13:58 ` [PATCH 06/11] [gdb/testsuite] Refactor exception handling Tom de Vries
2026-08-24 13:58 ` [PATCH 07/11] [gdb/testsuite] Refactor exception handling in gdb_expect Tom de Vries
2026-08-24 13:58 ` [PATCH 08/11] [gdb/testsuite] Refactor exception handling in gdb_test_multiple Tom de Vries
2026-08-25 7:29 ` Tom de Vries
2026-09-01 16:13 ` Keith Seitz
2026-09-24 16:03 ` Tom de Vries
2026-08-24 13:58 ` [PATCH 09/11] [gdb/testsuite] Refactor exception handling in lock_file_acquire/release Tom de Vries
2026-08-24 13:58 ` [PATCH 10/11] [gdb/testsuite] Refactor exception handling in tentative_rename Tom de Vries
2026-08-24 13:58 ` [PATCH 11/11] [gdb/testsuite] Refactor exception handling in with_stub_devices Tom de Vries
2026-09-01 16:10 ` Keith Seitz
2026-09-23 19:06 ` Tom de Vries
2026-09-01 17:07 ` [PATCH 00/11] [gdb/testsuite] Refactor exception handling Keith Seitz
2026-09-02 19:57 ` Tom Tromey
2026-09-24 16:08 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e24b0016-89cc-4285-a579-bf8c4ec79569@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox