Re: [PATCH 00/11] [gdb/testsuite] Refactor exception handling

[Keith Seitz <keiths@redhat.com>]

Hi,

On 8/24/26 6:58 AM, Tom de Vries wrote:
> This patch series does two things:
> - use modern exception handling constructs like try/finally and
>    "return -options" (PR34552).
> - fix bug in "return -level 2" handling (PR34553).

Thank you for simplifying this exception handling. I've sent
a few little nits, but otherwise, this LGTM.

Reviewed-By: Keith Seitz <keiths@redhat.com>

Keith

> 
> Tested on x86_64-linux.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34552
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34553
> 
> Tom de Vries (11):
>    [gdb/testsuite] Normalize indentation in with_test_prefix
>    [gdb/testsuite] Fix return -level 2 bug in with_test_prefix
>    [gdb/testsuite] Simplify foreach_with_prefix
>    [gdb/testsuite] Refactor exception handling in foreach_with_prefix
>    [gdb/testsuite] Add transparent_uplevel
>    [gdb/testsuite] Refactor exception handling
>    [gdb/testsuite] Refactor exception handling in gdb_expect
>    [gdb/testsuite] Refactor exception handling in gdb_test_multiple
>    [gdb/testsuite] Refactor exception handling in
>      lock_file_acquire/release
>    [gdb/testsuite] Refactor exception handling in tentative_rename
>    [gdb/testsuite] Refactor exception handling in with_stub_devices
> 
>   gdb/testsuite/gdb.rocm/hcc-amdgpu-targets.exp |  15 +-
>   .../gdb.testsuite/foreach_with_prefix.exp     |  27 ++
>   gdb/testsuite/gdb.testsuite/gdb-test.exp      |  51 ++
>   .../gdb.testsuite/with-test-prefix.exp        |  45 ++
>   gdb/testsuite/lib/ada.exp                     |  14 +-
>   gdb/testsuite/lib/dwarf.exp                   |  15 +-
>   gdb/testsuite/lib/gdb-utils.exp               |  45 +-
>   gdb/testsuite/lib/gdb.exp                     | 449 ++++++++----------
>   gdb/testsuite/lib/mi-support.exp              |  22 +-
>   gdb/testsuite/lib/tuiterm.exp                 |  15 +-
>   10 files changed, 383 insertions(+), 315 deletions(-)
>   create mode 100644 gdb/testsuite/gdb.testsuite/with-test-prefix.exp
> 
> 
> base-commit: 7063b767cc9c2774e7ead41144e5613bacad6a0d