From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G3xNM2MGl2osbRsAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 13:07:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OO/MlGgg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BB4EB1E033; Tue, 01 Sep 2026 13:07:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 83F4B1E033 for ; Tue, 01 Sep 2026 13:07:40 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECBDA4BA2E2B for ; Tue, 1 Sep 2026 17:07:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECBDA4BA2E2B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OO/MlGgg Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 0592A4BA2E0C for ; Tue, 1 Sep 2026 17:07:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0592A4BA2E0C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0592A4BA2E0C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788282435; cv=none; b=gPoZFJCaNypPi7USWDWF/vjh1oK4E1RN2Zj4z1p/esKb+8uRLdNXnxJPDx9MwOztxjgPVrv9GRxCKPJOpYnNFBYWbybTXCgSeWNxfmI5zmCimee/jv755Pkp9WyzDnfkQJrpWoH9LEDSK8IIup9BEIlWwvOJiCvkqAhj6zJIAN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788282435; c=relaxed/simple; bh=bMGU/X8TJHe7EntiN1nDDMknNLHLRitTgp7mtZDS/Xs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dwqTO+FnxPvin/uP0NgEleV+vlEjYw6NkUMa39bl2882GrzDkxGu8+cWQpN/GJbz6b9VsAWvQ0oTLytRFG2sX8QwcXP7mPOXLfWT09eTJ2DLfuOsjwFL0SHlcXEFb1TQ845+Ok4q8dip9svGdLvnGI0fonhnfCuEskQgmTs7w3E= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OO/MlGgg DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0592A4BA2E0C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788282434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ct1cSsCNr/+/vE+HJaL9UraLf39u1MLVZtuOIY44PtA=; b=OO/MlGggyM+/b1lWRXrWkCTEtvVEUVjb07XTzU8I6C9hBv/IQejVj5XjRe2gKBszG8FUyn qWIKxdeXZlsPGe5zhDTy6uYnWaEUnQKpYRClOve0f01puwkM0KAtEVgJktSCjsK23aGKn6 K+h9DrUSdSgRTwDJeUK+v5yUG1YpVrY= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-IOL56nOcPUW3uXujsj-Yuw-1; Tue, 01 Sept 2026 13:07:13 -0400 X-MC-Unique: IOL56nOcPUW3uXujsj-Yuw-1 X-Mimecast-MFC-AGG-ID: IOL56nOcPUW3uXujsj-Yuw_1788282433 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52ff59f2c47so1075831cf.1 for ; Tue, 01 Sep 2026 10:07:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788282433; x=1788887233; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ct1cSsCNr/+/vE+HJaL9UraLf39u1MLVZtuOIY44PtA=; b=itpRU3pu6jQxbYZM3Z8pZgSju71actFKEoRA156ZCsn6nbHOXrktXHFjMIIpTXkgBZ Gdtch7JnRlXfiLXe1705RdSrZJyDv16bYgxjSIqWEmPSdLC2nu7+Qawm/j/ldkqIJn3H Q5qjyAygdcn06BQYcN50b6kq1+GKuJagkyRjaRISV+QKUGTEQyQH5Qa2CxM2OVUSADg0 sfoOn51A51pcsTfIaGi7d2W72yDXSbOtPjWS/8HYvzoynzjD8N1Dn1uQsTC6qwMRv8mu lfoYsn2ZoUZi0GEO4Upos53NeZ7IKsLGdsF+X0Go1sgrHnnkJalzQZ4c0dNL4+/qq/rX 1U2w== X-Forwarded-Encrypted: i=1; AHgh+RrYXocBnaLYIua7u/qtRgK/K7cniwmfuomHT1/rC/3u9GaEHDlHGdRecp89IY59N5ofO/g5G2VhLV78CA==@sourceware.org X-Gm-Message-State: AFuF++mayApdYTcTmTyaT+MiEERRb4qOSHt6xaTGl7iH1hX0aahDdF72 sMFJsG20PREUeHiVOXXIVXmKilG9IRGZxvC+aHvJTswj2i/uxpsWpGZoxK6WpVZpLFYayy3q60y aDixRIVznt3BS15Fgm9DmTrtxNZybb/YkW6AokZlGUq9QZPUGxi84oBIh3WDUuL33BO/+NC0= X-Gm-Gg: AR+sD11D+izZBKvXNQlLHJRiDAC5b4J1c6lC6Osfx/4HNLm6QAcWBZRVCwlerr3ggbP 4tVm2kMgWWHr/1PUzNYu41kvf5mXbFS01vX2yAa06pi5CcGVnd8+Ft426Fp4LsGxnJ+uDPnQJDH 2sT3goJoHWlM+2Jrb/LURoOaA0YfnjUkaNgWfLEAXMrKkh2ngjku5TeCnfBKTmOUHuGLj+4xYDN KMaoTcJThQwiOCmVqeIXtCM+LClHQD5IBGDsEtXiZkjZRaHvzpeNuiwExKKLjhzelG949cCKVms InwLibcaSld56Mxzm+srs2G1fl8rUxnLUotrCHXejOMpTtMOSG0+9BIj/MMogT+6Dj7EkDUDiyn Ntd0kXw== X-Received: by 2002:ac8:5894:0:b0:51c:1ea:e290 with SMTP id d75a77b69052e-5302536a101mr91765791cf.17.1788282432995; Tue, 01 Sep 2026 10:07:12 -0700 (PDT) X-Received: by 2002:ac8:5894:0:b0:51c:1ea:e290 with SMTP id d75a77b69052e-5302536a101mr91764521cf.17.1788282432324; Tue, 01 Sep 2026 10:07:12 -0700 (PDT) Received: from [150.1.200.157] ([172.56.108.54]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-530330282bfsm1332291cf.11.2026.09.01.10.07.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 10:07:11 -0700 (PDT) Message-ID: Date: Tue, 1 Sep 2026 10:07:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/11] [gdb/testsuite] Refactor exception handling To: Tom de Vries , gdb-patches@sourceware.org References: <20260824135855.1195963-1-tdevries@suse.de> From: Keith Seitz In-Reply-To: <20260824135855.1195963-1-tdevries@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MQJ46SAb0aUM_PZjz0tw2aQ6u-uxN89a0jyexOYDICw_1788282433 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 8/24/26 6:58 AM, Tom de Vries wrote: > This patch series does two things: > - use modern exception handling constructs like try/finally and > "return -options" (PR34552). > - fix bug in "return -level 2" handling (PR34553). Thank you for simplifying this exception handling. I've sent a few little nits, but otherwise, this LGTM. Reviewed-By: Keith Seitz Keith > > Tested on x86_64-linux. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34552 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34553 > > Tom de Vries (11): > [gdb/testsuite] Normalize indentation in with_test_prefix > [gdb/testsuite] Fix return -level 2 bug in with_test_prefix > [gdb/testsuite] Simplify foreach_with_prefix > [gdb/testsuite] Refactor exception handling in foreach_with_prefix > [gdb/testsuite] Add transparent_uplevel > [gdb/testsuite] Refactor exception handling > [gdb/testsuite] Refactor exception handling in gdb_expect > [gdb/testsuite] Refactor exception handling in gdb_test_multiple > [gdb/testsuite] Refactor exception handling in > lock_file_acquire/release > [gdb/testsuite] Refactor exception handling in tentative_rename > [gdb/testsuite] Refactor exception handling in with_stub_devices > > gdb/testsuite/gdb.rocm/hcc-amdgpu-targets.exp | 15 +- > .../gdb.testsuite/foreach_with_prefix.exp | 27 ++ > gdb/testsuite/gdb.testsuite/gdb-test.exp | 51 ++ > .../gdb.testsuite/with-test-prefix.exp | 45 ++ > gdb/testsuite/lib/ada.exp | 14 +- > gdb/testsuite/lib/dwarf.exp | 15 +- > gdb/testsuite/lib/gdb-utils.exp | 45 +- > gdb/testsuite/lib/gdb.exp | 449 ++++++++---------- > gdb/testsuite/lib/mi-support.exp | 22 +- > gdb/testsuite/lib/tuiterm.exp | 15 +- > 10 files changed, 383 insertions(+), 315 deletions(-) > create mode 100644 gdb/testsuite/gdb.testsuite/with-test-prefix.exp > > > base-commit: 7063b767cc9c2774e7ead41144e5613bacad6a0d