Re: [PATCH 02/11] [gdb/testsuite] Fix return -level 2 bug in with_test_prefix

[Tom de Vries <tdevries@suse.de>]

On 9/23/26 11:36 PM, Tom de Vries wrote:
> On 9/2/26 9:46 PM, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>
>> Tom> Fix this by:
>> Tom> - using "catch {...} result opts" to capture the return options 
>> dictionary
>> Tom> - increasing -level in $opts, and
>> Tom> - using return -options $opts,
>> Tom> reducing exception handling to just two lines:
>> Tom> ...
>> Tom>     catch {uplevel 1 $body} result opts
>> Tom>     ...
>> Tom>     return -options [dict incr opts -level 1] $result
>> Tom> ...
>>
>> It wasn't clear to me, but does this formulation also work correctly for
>> things other than 'return' and 'error'?  Like, are 'break' and
>> 'continue' properly handled as well?
> 
> It does.  Your question made me realize that the series should be 
> restructured.
> 
> So, I started out with the patch introducing transparent_uplevel.
> 
> Then I added a test-case for transparent_uplevel that should answer your 
> question.
> 
> Then there's a number of trivial refactor patches using 
> transparent_uplevel and try/finally.
> 
> I'm pushing this part now, and then I'll have a look over the rest of 
> the series.

Ok, it seems that during restructuring, this patch got merged into 
"[gdb/testsuite] Refactor exception handling" and committed so this 
patch can be dropped.

Thanks,
- Tom