From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pfkWMk4xtWpEDj0AWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 10:18:54 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t04yiOnH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=MIDUrj1L; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JnOQBy9y; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OL3HBpu5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AF3E91E06B; Thu, 24 Sep 2026 10:18:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DC1711E01F for ; Thu, 24 Sep 2026 10:18:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 072ED4BB589C for ; Thu, 24 Sep 2026 14:18:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 072ED4BB589C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t04yiOnH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=MIDUrj1L; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JnOQBy9y; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OL3HBpu5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 5EC8A4BB3BFB for ; Thu, 24 Sep 2026 14:18:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5EC8A4BB3BFB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5EC8A4BB3BFB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790259509; cv=none; b=sCXiliABTbFPs80TNbPNwrtqFye/p/15PZYtXdnWIA/smAuoDP5Ckaaog3lyaBNbgl3viqiE1CXsz4Y1JdcytNLVshEIuUXAr/pNPmi2LBW44ivQWz+UFM2KaS+rfGwxuBcVlrnSzaQhsaU9IpSmaxHEM3P0dVHG4ikaHfYL/KQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790259509; c=relaxed/simple; bh=wH1B0HDhYZI8ZpainIEnGmGIeDnnUWLzHFd7CLHFbJo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=nrlNZj9z/irUw8PUH2/R3XcFzqzMtJtumxPgMUj/hI0HsQycYOC4lsvWAv1LrrbHYD/Hd7sGIypGsOSmrUyVN/THtWTG/3ioyMdxQAp3u/j/ClqwJGcrrVEAtWpyheGgu5SNbBwEgMavUu/H0LbTweW4bdrJ4/ck/wgJXa2rxWs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t04yiOnH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=MIDUrj1L; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JnOQBy9y; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OL3HBpu5 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5EC8A4BB3BFB Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9EB2821F9E; Thu, 24 Sep 2026 14:18:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790259503; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItXjXJh3LQIoFBsPNaLGPgh9UVUBnIQY+SDC2JQBGac=; b=t04yiOnHRdVkh6KzvZEHQaugAVMXKE2TlGzNQliBZJHwHzbm/i8+spxAOXObygSe/k6lyE MPnsfSri1/bA+zUGVX8bQvAC+cujQ8UOr/3Kt4z7HwlVYlBSHlx7q5BbYKlDe5CJR+mcnR KnrSluiTW0UVpA4EciVp2YKCyoKKFCw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790259503; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItXjXJh3LQIoFBsPNaLGPgh9UVUBnIQY+SDC2JQBGac=; b=MIDUrj1LMpXc+bmGXmIWrlRyeje8PWeCyh9weR7oltuxkPPN1U3uRHiTgjP/MGLkVwjqA4 M4LHaaRNcaF1u1Dg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790259499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItXjXJh3LQIoFBsPNaLGPgh9UVUBnIQY+SDC2JQBGac=; b=JnOQBy9yFlLr7HpDr+97b0C+AnrYesbCSRFgLjrgEfZd0CduLFSJV/Eqo43TPE1B8y6lOu 7qAIpGizxHBU4CbQgIFKI2Ahb40isVWh61bgMAQW2iPClo0kI+w2m7ipwNYi6EPkD7F6YT 2EZwYX0XNPqJRD2d1TlqkORtgDnRv80= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790259499; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItXjXJh3LQIoFBsPNaLGPgh9UVUBnIQY+SDC2JQBGac=; b=OL3HBpu5bljqfjx3VnoE++DBMIXVm+7hpVk5FNgOxow0upM4BXv25o2uaE8HQMVFA7yKKa 35hC6aYqo9EPPoBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 681B413354; Thu, 24 Sep 2026 14:18:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wortCisxtWrbYgAAD6G6ig (envelope-from ); Thu, 24 Sep 2026 14:18:19 +0000 Message-ID: <0f73b1d6-49f6-457c-bf45-1eb2e961aa30@suse.de> Date: Thu, 24 Sep 2026 16:18:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/11] [gdb/testsuite] Fix return -level 2 bug in with_test_prefix From: Tom de Vries To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260824135855.1195963-1-tdevries@suse.de> <20260824135855.1195963-3-tdevries@suse.de> <87bjaf4erz.fsf@tromey.com> <2e103a39-03c2-4dcb-acf0-8d16b3e52eb6@suse.de> Content-Language: en-US In-Reply-To: <2e103a39-03c2-4dcb-acf0-8d16b3e52eb6@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/23/26 11:36 PM, Tom de Vries wrote: > On 9/2/26 9:46 PM, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> >> Tom> Fix this by: >> Tom> - using "catch {...} result opts" to capture the return options >> dictionary >> Tom> - increasing -level in $opts, and >> Tom> - using return -options $opts, >> Tom> reducing exception handling to just two lines: >> Tom> ... >> Tom>     catch {uplevel 1 $body} result opts >> Tom>     ... >> Tom>     return -options [dict incr opts -level 1] $result >> Tom> ... >> >> It wasn't clear to me, but does this formulation also work correctly for >> things other than 'return' and 'error'?  Like, are 'break' and >> 'continue' properly handled as well? > > It does.  Your question made me realize that the series should be > restructured. > > So, I started out with the patch introducing transparent_uplevel. > > Then I added a test-case for transparent_uplevel that should answer your > question. > > Then there's a number of trivial refactor patches using > transparent_uplevel and try/finally. > > I'm pushing this part now, and then I'll have a look over the rest of > the series. Ok, it seems that during restructuring, this patch got merged into "[gdb/testsuite] Refactor exception handling" and committed so this patch can be dropped. Thanks, - Tom