From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BlR8MA0jtGqLvDgAWB0awg (envelope-from ) for ; Wed, 23 Sep 2026 15:05:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ogDaI7Xd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nStBSrXe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Py/3dbQs; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gzgYmku6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AD3C51E01F; Wed, 23 Sep 2026 15:05:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 042A41E01F for ; Wed, 23 Sep 2026 15:05:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90F9C4BB3BCA for ; Wed, 23 Sep 2026 19:05:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90F9C4BB3BCA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ogDaI7Xd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nStBSrXe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Py/3dbQs; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gzgYmku6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 495244BB3BC0 for ; Wed, 23 Sep 2026 19:05:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 495244BB3BC0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 495244BB3BC0 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790190322; cv=none; b=up6UAihXvQ/nIVcL4z0JtO6CWSw0p3B1XbsFYcyPDyrnjdWUnCF7OL0pjRHPa0vedZaREeVQSdaumVKgY7veRnXc+ZfFuWoI3br64TOvzoblIdpn1BQxYFsLtsowBxXBHW4qaHV0VGUEHgv80wiqibWP20VF00symRybmx/RB4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790190322; c=relaxed/simple; bh=f4gCQiyKdEX4SdRt9r/t3pZUKOZCxmKdFJDackdtPa8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ey56qIAEuYiNKmbkirofRqZPxDROObJgv0Qvn4e9cvCShmQMKDOuxcwT5SDg01qFP9xhTuk22HUz3GaFpF9SkcgfGxlU+JSKwaJvGidhuZcFtcw6Nsuyacz7vvaVsED6wyQlamHuppP2aGGSxzu5y/3FMoQl35aI05oyPdcYYHE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ogDaI7Xd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nStBSrXe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Py/3dbQs; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gzgYmku6 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 495244BB3BC0 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F358F21CD2; Wed, 23 Sep 2026 19:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790190317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXBS7nROthh32cY8xd0rq+ZRkcqLDNDH2WDSbALjGYU=; b=ogDaI7Xdi4Och3roWriQyLachjzKOhPBVDZrvM3Sj4sS8r7DfhwrJ+x+rjjNIsB9wKSKVp 0lbO+34KTRuVLabBgFu9T+6oHEgcnMcW2e5j4h4Q+EAXkE+kkpI+FYX5OMv/lXddQC0X7Z 3auTBUiiT0QTj90Y6kf7zyJDM7JWWFo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790190317; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXBS7nROthh32cY8xd0rq+ZRkcqLDNDH2WDSbALjGYU=; b=nStBSrXei0iJ59GOVXTtMAXUrJNHA4yMf/Plbww9nMO/X9vtfK6F7yjEIJTNAUU46qkKXM 94nlNTqHb5+Mm4Dw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790190313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXBS7nROthh32cY8xd0rq+ZRkcqLDNDH2WDSbALjGYU=; b=Py/3dbQsVJ8jxySHCGNC2b4ytagTOLbedBPpT5sZKaYpSeIwLNejR5SyHEhoIAnbmF9cHX zHZanCbRx1OEQ5Ol2n4y9ihVEv65XObKyArJ9DGMg27mlwUvgK4euuXDgF+xsCuEcjAK7O WoFoYDNURl1daWjRoCfSiCiXd03YldA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790190313; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXBS7nROthh32cY8xd0rq+ZRkcqLDNDH2WDSbALjGYU=; b=gzgYmku6bqrT8xzQT56xlKcVRoxlHZSdKrxZW3JupL5nQobUmGjAWVHc3cIK7axoaqk/2y hcy8YZDL7DoqlpBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 974BD134E8; Wed, 23 Sep 2026 19:05:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yRqHGegitGqXEgAAD6G6ig (envelope-from ); Wed, 23 Sep 2026 19:05:12 +0000 Message-ID: Date: Wed, 23 Sep 2026 21:05:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/11] [gdb/testsuite] Add transparent_uplevel To: Keith Seitz , gdb-patches@sourceware.org References: <20260824135855.1195963-1-tdevries@suse.de> <20260824135855.1195963-6-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/1/26 6:16 PM, Keith Seitz wrote: >>   } >> +# Run BODY in the context of the callers caller. > > Typo: "caller's caller". > >> +# >> +# To be used in a proc foo: >> +#   proc foo {body} { >> +#       transparent_uplevel body >> +#   } > > I think "body" here is missing a '$'? Hi Keith, thanks for the reviews. I've fixed these two locally, and am about to push. [ FWIW, I've debugged my LLM review setup for a bit to find out why these, as well as the others you mentioned in this series weren't found. That is still ongoing, but I hope that future submissions will be better. ] Thanks, - Tom