Re: [PATCH] Add completion styling

[Philippe Waroquiers <philippe.waroquiers@skynet.be>]

On Sat, 2020-05-23 at 14:52 -0600, Tom Tromey wrote:
> > > > > > "Tom" == Tom Tromey <tom@tromey.com> writes:
> 
> Tom> I think the Emacs idea is nice.  Maybe we want to let the user control
> Tom> the prefix text, the "difference character", and the final completion
> Tom> text.
> 
> > Here's a new version of the patch that implements this idea.
> 
> I'm checking this in.
I played with it, nice.

A suggestion:
If easy to do, it would be nice to also have coloring in the ambiguous output:
  (gdb) di
  Ambiguous command "di": directory, dis, disa, disable, disassemble, disconnect, display.
(but I guess this might not be easy if the coloring is done by readline,
and the ambiguous list is produced by GDB).

Another suggestion:
I am wondering why completion-difference is not used to color the full set
of characters needed to make a command non-ambiguous.

For example, when completing <di>, it would be nice to color <sc> of disconnect
and color <sp> of display, <sas> of disassemble, ....

The idea is to show what must be typed specifically to have this command,
rather than show one letter but still giving something ambiguous needing
further completion.

Currently, only the 3rd letter is colored: 
e.g.<s> is colored, but it implies then to type <s> then tab
then <c> (and maybe tab again if you want to be sure) before having the command
you want.

Philippe