Re: [PATCH] Add completion styling

[Eli Zaretskii <eliz@gnu.org>]

> Cc: tom@tromey.com, gdb-patches@sourceware.org
> From: Pedro Alves <palves@redhat.com>
> Date: Sun, 24 May 2020 16:30:07 +0100
> 
> >> while it should highlight here:
> >>
> >> selftests::string_view::cons_1::main()
> >> selftests::string_view::cons_2::main()
> >> selftests::string_view::cons_3::main()
> >>                                     ^
> > 
> > Really? not here:
> > 
> >  selftests::string_view::cons_1::main()
> >                               ^
> 
> I don't understand.  Under the "1"?  Why?  

because that's the first difference between the candidates.

> My understanding is that "set style completion-difference" highlights the
> first character that follows the string that the user typed, right?

No, it highlights the first character from the left that distinguishes
between candidates.  That is the character the user _has_ to type to
narrow his/her choice, potentially resolving it to a single candidate.

> > But I actually don't understand how did we get these candidates by
> > typing "main".  Don't we complete by looking for strings that begin
> > with what the user typed?  I'm probably missing something here.
> 
> You're missing that "b main" sets a breakpoint on every "main"
> function in every namespace.

OK, but then I still stand by my expectations.  Although implementing
that may not be easy given that the candidates don't start with what
the user typed.