From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add completion styling
Date: Sun, 24 May 2020 12:16:37 +0200 [thread overview]
Message-ID: <3729ba46-fc95-ddda-bf7e-d52f6681d347@suse.de> (raw)
In-Reply-To: <87a71ytlue.fsf@tromey.com>
On 23-05-2020 22:52, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> I think the Emacs idea is nice. Maybe we want to let the user control
> Tom> the prefix text, the "difference character", and the final completion
> Tom> text.
>
>> Here's a new version of the patch that implements this idea.
>
> I'm checking this in.
I'm seeing regressions due to this patch, sofar:
...
FAIL: gdb.base/completion.exp: complete (2) 'p 'arg' (timeout)
FAIL: gdb.base/completion.exp: complete 'handle signal' (timeout)
FAIL: gdb.base/completion.exp: complete 'handle keyword' (timeout)
FAIL: gdb.base/completion.exp: complete help aliases (timeout)
FAIL: gdb.base/completion.exp: complete 'p no_var_named_this-arg' (timeout)
FAIL: gdb.base/completion.exp: complete (2) 'p no_var_named_this-arg'
(timeout)
FAIL: gdb.base/completion.exp: complete (2) 'p no_var_named_this-' (timeout)
FAIL: gdb.base/completion.exp: complete 'p values[0].a' (timeout)
FAIL: gdb.base/completion.exp: complete 'p values[0] . a' (timeout)
FAIL: gdb.base/completion.exp: complete 'p &values[0] -> a' (timeout)
FAIL: gdb.base/completion.exp: completion of field in anonymous union
FAIL: gdb.base/completion.exp: complete 'info func marke' (timeout)
FAIL: gdb.base/completion.exp: complete 'set follow-fork-mode' (timeout)
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
ERROR: internal buffer is full.
FAIL: gdb.base/filesym.exp: completion list for "filesym" (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-misc: tab
complete "maint test-options require-delimiter -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-flag: tab
complete "maint test-options require-delimiter -flag -" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-boolean: tab
complete "maint test-options require-delimiter -bool " (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-boolean: tab
complete "maint test-options require-delimiter -bool -" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-boolean: tab
complete "maint test-options require-delimiter -bool o" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-uinteger: tab
complete "maint test-options require-delimiter -uinteger " (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-uinteger: tab
complete "maint test-options require-delimiter -uinteger 1 " (second
tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-uinteger: tab
complete "maint test-options require-delimiter -zuinteger-unlimited "
(second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-uinteger: tab
complete "maint test-options require-delimiter -zuinteger-unlimited -1 "
(second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-uinteger: tab
complete "maint test-options require-delimiter -zuinteger-unlimited 1 "
(second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-enum: tab
complete "maint test-options require-delimiter -enum " (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string: str=STR:
tab complete "maint test-options require-delimiter -string STR -"
(second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string:
str="STR": tab complete "maint test-options require-delimiter -string
"STR" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string:
str=\"STR: tab complete "maint test-options require-delimiter -string
\"STR -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string:
str='STR': tab complete "maint test-options require-delimiter -string
'STR' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string:
str=\'STR: tab complete "maint test-options require-delimiter -string
\'STR -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string: str="STR
AAA": tab complete "maint test-options require-delimiter -string "STR
AAA" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string: str='STR
BBB': tab complete "maint test-options require-delimiter -string 'STR
BBB' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string: str="STR
'CCC' DDD": tab complete "maint test-options require-delimiter -string
"STR 'CCC' DDD" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string: str='STR
"EEE" FFF': tab complete "maint test-options require-delimiter -string
'STR "EEE" FFF' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string: str="STR
\"GGG\" HHH": tab complete "maint test-options require-delimiter -string
"STR \"GGG\" HHH" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=require-delimiter: test-string: str='STR
\'III\' JJJ': tab complete "maint test-options require-delimiter -string
'STR \'III\' JJJ' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-misc: tab
complete "maint test-options unknown-is-error -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-flag: tab
complete "maint test-options unknown-is-error -flag -" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-boolean: tab
complete "maint test-options unknown-is-error -bool -" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-boolean: tab
complete "maint test-options unknown-is-error -bool o" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-uinteger: tab
complete "maint test-options unknown-is-error -uinteger " (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-uinteger: tab
complete "maint test-options unknown-is-error -zuinteger-unlimited "
(second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-enum: tab
complete "maint test-options unknown-is-error -enum " (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string: str=STR:
tab complete "maint test-options unknown-is-error -string STR -" (second
tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string:
str="STR": tab complete "maint test-options unknown-is-error -string
"STR" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string:
str=\"STR: tab complete "maint test-options unknown-is-error -string
\"STR -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string:
str='STR': tab complete "maint test-options unknown-is-error -string
'STR' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string:
str=\'STR: tab complete "maint test-options unknown-is-error -string
\'STR -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string: str="STR
AAA": tab complete "maint test-options unknown-is-error -string "STR
AAA" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string: str='STR
BBB': tab complete "maint test-options unknown-is-error -string 'STR
BBB' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string: str="STR
'CCC' DDD": tab complete "maint test-options unknown-is-error -string
"STR 'CCC' DDD" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string: str='STR
"EEE" FFF': tab complete "maint test-options unknown-is-error -string
'STR "EEE" FFF' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string: str="STR
\"GGG\" HHH": tab complete "maint test-options unknown-is-error -string
"STR \"GGG\" HHH" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-error: test-string: str='STR
\'III\' JJJ': tab complete "maint test-options unknown-is-error -string
'STR \'III\' JJJ' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-misc: tab
complete "maint test-options unknown-is-operand -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-flag: tab
complete "maint test-options unknown-is-operand -flag -" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-boolean: tab
complete "maint test-options unknown-is-operand -bool -" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-boolean: tab
complete "maint test-options unknown-is-operand -bool o" (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-uinteger: tab
complete "maint test-options unknown-is-operand -uinteger " (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-uinteger: tab
complete "maint test-options unknown-is-operand -zuinteger-unlimited "
(second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-enum: tab
complete "maint test-options unknown-is-operand -enum " (second tab)
(timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str=STR: tab complete "maint test-options unknown-is-operand -string STR
-" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str="STR": tab complete "maint test-options unknown-is-operand -string
"STR" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str=\"STR: tab complete "maint test-options unknown-is-operand -string
\"STR -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str='STR': tab complete "maint test-options unknown-is-operand -string
'STR' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str=\'STR: tab complete "maint test-options unknown-is-operand -string
\'STR -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str="STR AAA": tab complete "maint test-options unknown-is-operand
-string "STR AAA" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str='STR BBB': tab complete "maint test-options unknown-is-operand
-string 'STR BBB' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str="STR 'CCC' DDD": tab complete "maint test-options unknown-is-operand
-string "STR 'CCC' DDD" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str='STR "EEE" FFF': tab complete "maint test-options unknown-is-operand
-string 'STR "EEE" FFF' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str="STR \"GGG\" HHH": tab complete "maint test-options
unknown-is-operand -string "STR \"GGG\" HHH" -" (second tab) (timeout)
FAIL: gdb.base/options.exp: cmd=unknown-is-operand: test-string:
str='STR \'III\' JJJ': tab complete "maint test-options
unknown-is-operand -string 'STR \'III\' JJJ' -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-print: tab complete "print -" (second
tab) (timeout)
FAIL: gdb.base/options.exp: test-print: tab complete "frame apply all
print -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-print: tab complete "frame apply 1
print -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-print: tab complete "frame apply level
0 print -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-print: tab complete "thread apply all
print -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-print: tab complete "thread apply 1
print -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-print: tab complete "thread apply 1
frame apply 1 print -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-backtrace: tab complete "backtrace -"
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
all " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
all -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab
complete "frame apply all -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
all -s " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
1 " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
1 -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab
complete "frame apply 1 -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
1 -s " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
level 0 " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
level 0 -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab
complete "frame apply level 0 -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply
level 0 -s " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas "
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas -"
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab
complete "faas -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas -s "
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas "
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas -"
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab
complete "tfaas -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas -s "
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread
apply all " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread
apply all -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab
complete "thread apply all -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread
apply all -c " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread
apply 1 " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread
apply 1 -" (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab
complete "thread apply 1 -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread
apply 1 -c " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas "
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas -"
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab
complete "taas -- " (second tab) (timeout)
FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas -c "
(second tab) (timeout)
FAIL: gdb.base/options.exp: test-info-threads: tab complete "info
threads " (second tab) (timeout)
FAIL: gdb.base/readline-ask.exp: more message for 01 and 02 (timeout)
FAIL: gdb.base/readline-ask.exp: more message for 03 (timeout)
FAIL: gdb.base/readline-ask.exp: more finish for 04 (timeout)
FAIL: gdb.base/readline-ask.exp: ask message for 01 and 02 (timeout)
FAIL: gdb.base/settings.exp: test-integer zuinteger: tab complete "maint
set test-settings zuinteger" (second tab) (timeout)
FAIL: gdb.base/settings.exp: test-integer zuinteger: tab complete
"maintenance show test-settings zuinteger" (second tab) (timeout)
FAIL: gdb.base/settings.exp: test-boolean: tab complete "maint set
test-settings boolean " (second tab) (timeout)
FAIL: gdb.base/settings.exp: test-auto-boolean: tab complete "maint set
test-settings auto-boolean " (second tab) (timeout)
FAIL: gdb.base/settings.exp: test-enum: tab complete "maint set
test-settings enum " (second tab) (timeout)
FAIL: gdb.base/settings.exp: test-string string: tab complete "maint
show test-settings string" (second tab) (timeout)
FAIL: gdb.base/shell.exp: tab complete "pipe " (second tab) (timeout)
FAIL: gdb.base/shell.exp: tab complete "| " (second tab) (timeout)
FAIL: gdb.base/shell.exp: tab complete "|" (second tab) (timeout)
FAIL: gdb.base/skip.exp: skip delete completion: tab complete "skip
delete " (second tab) (timeout)
FAIL: gdb.base/skip.exp: skip delete completion: tab complete "skip
delete 1" (second tab) (timeout)
FAIL: gdb.base/skip.exp: skip delete completion: tab complete "skip
delete 2 " (second tab) (timeout)
FAIL: gdb.base/skip.exp: skip delete completion: tab complete "skip
delete 2-" (second tab) (timeout)
FAIL: gdb.base/with.exp: completion: tab complete "with print elements
unlimited -- " (second tab) (timeout)
FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete
"p Test_NS" (second tab) (timeout)
FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete
"p Test_NS:" (second tab) (timeout)
FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete
"p Test_NS::" (second tab) (timeout)
...
Thanks,
- Tom
next prev parent reply other threads:[~2020-05-24 10:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 2:41 Tom Tromey
2020-04-09 6:39 ` Eli Zaretskii
2020-04-24 19:51 ` Tom Tromey
2020-04-24 20:00 ` Eli Zaretskii
2020-04-24 20:37 ` Tom Tromey
2020-05-16 19:18 ` Tom Tromey
2020-05-16 19:25 ` Eli Zaretskii
2020-05-23 20:52 ` Tom Tromey
2020-05-23 21:48 ` Philippe Waroquiers
2020-05-24 0:26 ` Hannes Domani
2020-05-24 10:16 ` Tom de Vries [this message]
2020-05-25 8:06 ` Tom de Vries
2020-05-24 14:54 ` Tom Tromey
2020-05-24 12:58 ` Pedro Alves
2020-05-24 14:42 ` Eli Zaretskii
2020-05-24 15:30 ` Pedro Alves
2020-05-24 16:29 ` Eli Zaretskii
2020-05-24 16:44 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3729ba46-fc95-ddda-bf7e-d52f6681d347@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox