Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tom@tromey.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add completion styling
Date: Sun, 24 May 2020 16:30:07 +0100	[thread overview]
Message-ID: <0bee2d7c-4fe2-f6ff-088a-2d0c2730fbc9@redhat.com> (raw)
In-Reply-To: <83a71xxul5.fsf@gnu.org>

On 5/24/20 3:42 PM, Eli Zaretskii wrote:
>> Cc: gdb-patches@sourceware.org
>> From: Pedro Alves <palves@redhat.com>
>> Date: Sun, 24 May 2020 13:58:02 +0100
>>
>> Try "b main[TAB]" when debugging GDB, and you'll see that GDB
>> highlights the "t" as the first different character here:
>>
>> selftests::string_view::cons_1::main()
>> selftests::string_view::cons_2::main()
>> selftests::string_view::cons_3::main()
>>     ^
>>
>> while it should highlight here:
>>
>> selftests::string_view::cons_1::main()
>> selftests::string_view::cons_2::main()
>> selftests::string_view::cons_3::main()
>>                                     ^
> 
> Really? not here:
> 
>  selftests::string_view::cons_1::main()
>                               ^

I don't understand.  Under the "1"?  Why?  
My understanding is that "set style completion-difference" highlights the
first character that follows the string that the user typed, right?
So if you type "b main[TAB]", for the "selftests::string_view::cons_1::main()"
symbol, after "main" comes the open parenthesis.  Just like here,
you get a highlight under the "t" in "maint":

maintenance_translate_address(char const*, int)
    ^

> But I actually don't understand how did we get these candidates by
> typing "main".  Don't we complete by looking for strings that begin
> with what the user typed?  I'm probably missing something here.

You're missing that "b main" sets a breakpoint on every "main"
function in every namespace.  "b -qualified main" disables that.

Thanks,
Pedro Alves



  reply	other threads:[~2020-05-24 15:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  2:41 Tom Tromey
2020-04-09  6:39 ` Eli Zaretskii
2020-04-24 19:51   ` Tom Tromey
2020-04-24 20:00     ` Eli Zaretskii
2020-04-24 20:37       ` Tom Tromey
2020-05-16 19:18     ` Tom Tromey
2020-05-16 19:25       ` Eli Zaretskii
2020-05-23 20:52       ` Tom Tromey
2020-05-23 21:48         ` Philippe Waroquiers
2020-05-24  0:26         ` Hannes Domani
2020-05-24 10:16         ` Tom de Vries
2020-05-25  8:06           ` Tom de Vries
2020-05-24 14:54         ` Tom Tromey
2020-05-24 12:58     ` Pedro Alves
2020-05-24 14:42       ` Eli Zaretskii
2020-05-24 15:30         ` Pedro Alves [this message]
2020-05-24 16:29           ` Eli Zaretskii
2020-05-24 16:44             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bee2d7c-4fe2-f6ff-088a-2d0c2730fbc9@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox