Re: [PATCH] Add completion styling

[Tom de Vries <tdevries@suse.de>]

On 24-05-2020 12:16, Tom de Vries wrote:
> On 23-05-2020 22:52, Tom Tromey wrote:
>>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>>
>> Tom> I think the Emacs idea is nice.  Maybe we want to let the user control
>> Tom> the prefix text, the "difference character", and the final completion
>> Tom> text.
>>
>>> Here's a new version of the patch that implements this idea.
>>
>> I'm checking this in.
> 
> I'm seeing regressions due to this patch, sofar:
> ...
> FAIL: gdb.base/completion.exp: complete (2) 'p 'arg' (timeout)

FWIW, I've looked into this FAIL and found that it's due to this regexp:
...
            -re "argv.*$gdb_prompt " {
...
trying to match:
...
^[[2marg^[[m^[[35mv^[[m
...

Thanks,
- Tom