Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map

[Lancelot SIX <Lancelot.Six@amd.com>]

On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> From: Simon Marchi <simon.marchi@efficios.com>
> 
> Since we have gdb::unordered_map, swap std::unordered_map for that.
> 

Hi,

That looks good to me, thanks.

Since it only touches the amdgpu backend,
Approved-By: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Best,
Lancelot.

> Change-Id: If2ef652fe18c1a440a25cff6131d29e37091bdbe
> ---
>   gdb/amd-dbgapi-target.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
> index 2bb79acd76f0..153a35f788ed 100644
> --- a/gdb/amd-dbgapi-target.c
> +++ b/gdb/amd-dbgapi-target.c
> @@ -24,6 +24,7 @@
>   #include "cli/cli-cmds.h"
>   #include "cli/cli-decode.h"
>   #include "cli/cli-style.h"
> +#include "gdbsupport/unordered_map.h"
>   #include "inf-loop.h"
>   #include "inferior.h"
>   #include "objfiles.h"
> @@ -207,7 +208,7 @@ struct amd_dbgapi_inferior_info
>       bool enabled = false;
>     } precise_memory;
> 
> -  std::unordered_map<decltype (amd_dbgapi_breakpoint_id_t::handle),
> +  gdb::unordered_map<decltype (amd_dbgapi_breakpoint_id_t::handle),
>                       struct breakpoint *>
>       breakpoint_map;
> 
> @@ -221,7 +222,7 @@ struct amd_dbgapi_inferior_info
> 
>        wave_info objects are added when we first see the wave, and
>        removed from a thread_deleted observer.  */
> -  std::unordered_map<decltype (amd_dbgapi_wave_id_t::handle), wave_info>
> +  gdb::unordered_map<decltype (amd_dbgapi_wave_id_t::handle), wave_info>
>       wave_info_map;
>   };
> 
> --
> 2.47.1
>