From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <Lancelot.Six@amd.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map
Date: Wed, 15 Jan 2025 13:41:25 -0500 [thread overview]
Message-ID: <54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca> (raw)
In-Reply-To: <dbe26a98-437b-4739-aaee-2175ba3f4ff4@amd.com>
On 2025-01-15 05:55, Lancelot SIX wrote:
>
>
> On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote:
>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>
>>
>> From: Simon Marchi <simon.marchi@efficios.com>
>>
>> Since we have gdb::unordered_map, swap std::unordered_map for that.
>>
>
> Hi,
>
> That looks good to me, thanks.
>
> Since it only touches the amdgpu backend,
> Approved-By: Lancelot Six <lancelot.six@amd.com> (amdgpu)
Thanks, added.
Is the (amdgpu) some format we use? I haven't seen it used anywhere
else. I don't mind, for instance, Eli could use Approved-By with (doc).
Simon
next prev parent reply other threads:[~2025-01-15 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 19:16 [PATCH 0/3] Add displaced stepping support for AMD GPUs simon.marchi
2025-01-14 19:16 ` [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map simon.marchi
2025-01-15 10:55 ` Lancelot SIX
2025-01-15 18:41 ` Simon Marchi [this message]
2025-01-15 18:46 ` Simon Marchi
2025-01-15 18:50 ` Guinevere Larsen
2025-01-15 18:55 ` Lancelot SIX
2025-01-14 19:16 ` [PATCH 2/3] gdb: add target displaced stepping support simon.marchi
2025-01-14 19:16 ` [PATCH 3/3] gdb/amd-dbgapi: add " simon.marchi
2025-01-15 11:02 ` Lancelot SIX
2025-01-15 18:45 ` Simon Marchi
2025-02-25 17:17 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox