Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map

[Lancelot SIX <Lancelot.Six@amd.com>]

On 15/01/2025 18:41, Simon Marchi wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On 2025-01-15 05:55, Lancelot SIX wrote:
>>
>>
>> On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote:
>>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>>
>>>
>>> From: Simon Marchi <simon.marchi@efficios.com>
>>>
>>> Since we have gdb::unordered_map, swap std::unordered_map for that.
>>>
>>
>> Hi,
>>
>> That looks good to me, thanks.
>>
>> Since it only touches the amdgpu backend,
>> Approved-By: Lancelot Six <lancelot.six@amd.com> (amdgpu)
> 
> Thanks, added.
> 
> Is the (amdgpu) some format we use?  I haven't seen it used anywhere
> else.  I don't mind, for instance, Eli could use Approved-By with (doc).
> 
> Simon

This was discussed when introducing the trailer tags for reviews, and is 
documented in the gdb/MAINTAINERS file (thanks Gwen for that).

   - Approved-By:

    […]
    This trailer can be specific to one or more areas of the project, as
    defined by the "Responsible maintainers" section of this file.  If
    that is the case, the area(s) should be added at the end of the tag
    in parenthesis in a comma separated list.

There are a couple of other instances of that already:

     $ git log origin/master |grep -i Approved-by: | sort |uniq|grep \(
       Approved-By: G... L... <...> (record-full)
       Approved-By: L... S... <...> (amdgpu)
       Approved-By: L... M... <...> (aarch64/arm)

Best,
Lancelot.