Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map

[Guinevere Larsen <guinevere@redhat.com>]

On 1/15/25 3:46 PM, Simon Marchi wrote:
>
> On 2025-01-15 13:41, Simon Marchi wrote:
>>
>> On 2025-01-15 05:55, Lancelot SIX wrote:
>>>
>>> On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote:
>>>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>>>
>>>>
>>>> From: Simon Marchi <simon.marchi@efficios.com>
>>>>
>>>> Since we have gdb::unordered_map, swap std::unordered_map for that.
>>>>
>>> Hi,
>>>
>>> That looks good to me, thanks.
>>>
>>> Since it only touches the amdgpu backend,
>>> Approved-By: Lancelot Six <lancelot.six@amd.com> (amdgpu)
>> Thanks, added.
>>
>> Is the (amdgpu) some format we use?  I haven't seen it used anywhere
>> else.  I don't mind, for instance, Eli could use Approved-By with (doc).

It was the thing we agreed on when I added the trailer information to 
the maintainers file. The examples specifically use a comma separated 
list of areas in parenthesis after the tag.

> Just note that `b4 am` doesn't preserve the parenthesis, so it's not so
> handy actually.
>
> Simon
>
Ah, that's unfortunate. We might want to update that format then, but we 
should also update the maintainers file

-- 
Cheers,
Guinevere Larsen
She/Her/Hers