From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GJYVFI8DiGdvNxAAWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 13:50:55 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QDDxbHlf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4DF3F1E100; Wed, 15 Jan 2025 13:50:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CEE6F1E05C for ; Wed, 15 Jan 2025 13:50:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D5C838515C2 for ; Wed, 15 Jan 2025 18:50:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D5C838515C2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QDDxbHlf Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A988A3851A9A for ; Wed, 15 Jan 2025 18:50:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A988A3851A9A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A988A3851A9A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736967019; cv=none; b=p6X+l7IeJbF8YHhQT9Y83p0gQUvIzb8cLBvT/IvRDy9lrUO/YsrFObriWPKxqBzgxxnuQ99ycbLGLsWFVasXzgkS80fLzK9T5CKfadp0CH0ru+JbgFyYEyjfy70owZ4XVSYg42pDIoCwa/gRcnc00/tezg3NFUCfZabptOh2Y7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736967019; c=relaxed/simple; bh=JYJXj8J4mOi24eoVhqP6wP309JgmMfVgGzmrP0riNvM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tfxCMtC2MVZVN4rQ5SZkDF1m9px+k7SBd4YAaUSn+ECopzrTYvlaHzUwiucAP0QcZVK8X9PEpDEcM9D/NMiZviA9jAXhskdKUWBKPZq4M+fMO82ETGQ47TUdTVdiDBfUsJbuZG4kpLLcJ0evB8Fo+xiI8fOz8V8tuckEFN1o8bg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A988A3851A9A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736967019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qznLHhlpx2spojbPbzCq3ArgGMUcc65VyK8Ss3L0Byw=; b=QDDxbHlfg/yYrelhCEdY6JLH0LTCVdgx72b/CN/NJoLUUN2S4BKg+laGH97SMsscfpiK8Z UA4pXfxnyq4dqRx95/FRrmst7Zu1Y5MeTCrRRxdmdIOjRTgjfpI1jXe94SH6Q843j7rqEQ Yoe6FlVjImRuue7KUWwYjWVRG0j6+Hc= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-zvdExZaRPOyQn7zFhX0ajA-1; Wed, 15 Jan 2025 13:50:18 -0500 X-MC-Unique: zvdExZaRPOyQn7zFhX0ajA-1 X-Mimecast-MFC-AGG-ID: zvdExZaRPOyQn7zFhX0ajA Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3eb370d6135so62305b6e.1 for ; Wed, 15 Jan 2025 10:50:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736967016; x=1737571816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qznLHhlpx2spojbPbzCq3ArgGMUcc65VyK8Ss3L0Byw=; b=A2A3XEXrK6ViYXF9w59X+N5aT4D5dcNwOXTVaMcE8lNpX1XimKtGe0cHBUz++vvw4F 3yYCInmEvBL5aM3Y+XZaG9GvQyZI3te/AO5ic9hggxjFikiL1THweZlNCKxl3+xXDRnW n/aC26IOUD3+o6iyLHryusTNVoqVzpPdear0UorRZuAg48B/6wsNMCD89tPCzPnEaoye StoiewOf89g75GzVXh5CJ7ClQ/lukV0GGZw5FyxuvZYomPLNlhgV9wnlXC5IOb/HGy8R so7WZJnTIXuxBGcAdJ0KZpwGZnagQsHHDSOTNr/XpH/pfGDobadY3aMoHrfn4/Jgku25 wIHw== X-Forwarded-Encrypted: i=1; AJvYcCVDPSJg/0KxuBAngEHG/p9lMqfgCezZEjCM/Xqw9FOBZyrTuOz3uOnANCO1GnYqHvds4NU77qBVg5dLHg==@sourceware.org X-Gm-Message-State: AOJu0Yy7Z79vxi1C8S+4e4eDQ2mKavPYi+G4wGZBv/tV8YkU+CowqD+J 2O5zfJLKBcuxFepAu9AckDpgEIAplGAAQd6jnfoXFcARbPtCnmJ8+Exay3iCyCq1mIbeMy6eMfl Zp1Jt3V0Jmvzg7r+zsU3TDgM6SYpCxkimH87la9h5xSZsE+H03xYJCWM/xMtWWZRlFJM= X-Gm-Gg: ASbGncsSX3/yGR4jGoA8Ztw7ProChrJBy72QTauG1Nyv/Uh/fkJ+baqjl8G2aBhQCEd up3Yz7C+tdGWGr5o+GsOshMYFmLtDnt8JEUsswsln5moIZbvlOqGK37psPiR2HXfa2P4TIShHJv 8NCDFJYhlPdXmKM0ovHzq/dGRU7EmCvYZ8WIYUhr8ZH8BwcjtfAKQ81+z6xeCJ3cQxBIXMllEoM 2HTNj4+mLtXoEK7nCbTbD8yMs/+8yM8RabuvG8ZtdnFAb8efGtJ9drBUIwC2oLD1zBn X-Received: by 2002:a05:6808:2005:b0:3e6:147:6c5 with SMTP id 5614622812f47-3ef2ecc317bmr15748901b6e.10.1736967016461; Wed, 15 Jan 2025 10:50:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSCSjObosjQMbT5VKBwowwp+mgopRttLpZvX8id9sSKcdx+dbfw6m3sVoUvvBDVSyrTfGJyA== X-Received: by 2002:a05:6808:2005:b0:3e6:147:6c5 with SMTP id 5614622812f47-3ef2ecc317bmr15748887b6e.10.1736967016120; Wed, 15 Jan 2025 10:50:16 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f037653ff2sm5183896b6e.13.2025.01.15.10.50.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2025 10:50:15 -0800 (PST) Message-ID: Date: Wed, 15 Jan 2025 15:50:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map To: Simon Marchi , Simon Marchi , Lancelot SIX , gdb-patches@sourceware.org Cc: Simon Marchi References: <20250114191818.2393132-1-simon.marchi@polymtl.ca> <20250114191818.2393132-2-simon.marchi@polymtl.ca> <54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca> <49b2c439-b459-480c-9918-64344424c5b6@simark.ca> From: Guinevere Larsen In-Reply-To: <49b2c439-b459-480c-9918-64344424c5b6@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: svFRXMblSf_x3ZUcItnMZyMTC9SapwrNasHz7p0iT-g_1736967017 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/15/25 3:46 PM, Simon Marchi wrote: > > On 2025-01-15 13:41, Simon Marchi wrote: >> >> On 2025-01-15 05:55, Lancelot SIX wrote: >>> >>> On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote: >>>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. >>>> >>>> >>>> From: Simon Marchi >>>> >>>> Since we have gdb::unordered_map, swap std::unordered_map for that. >>>> >>> Hi, >>> >>> That looks good to me, thanks. >>> >>> Since it only touches the amdgpu backend, >>> Approved-By: Lancelot Six (amdgpu) >> Thanks, added. >> >> Is the (amdgpu) some format we use? I haven't seen it used anywhere >> else. I don't mind, for instance, Eli could use Approved-By with (doc). It was the thing we agreed on when I added the trailer information to the maintainers file. The examples specifically use a comma separated list of areas in parenthesis after the tag. > Just note that `b4 am` doesn't preserve the parenthesis, so it's not so > handy actually. > > Simon > Ah, that's unfortunate. We might want to update that format then, but we should also update the maintainers file -- Cheers, Guinevere Larsen She/Her/Hers