From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yBt3E9gEiGdVOBAAWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 13:56:24 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=rVh/kXiq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 496F51E100; Wed, 15 Jan 2025 13:56:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D5E521E05C for ; Wed, 15 Jan 2025 13:56:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D38938515D4 for ; Wed, 15 Jan 2025 18:56:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D38938515D4 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=rVh/kXiq Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20612.outbound.protection.outlook.com [IPv6:2a01:111:f403:2418::612]) by sourceware.org (Postfix) with ESMTPS id 40E9738515C8 for ; Wed, 15 Jan 2025 18:55:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40E9738515C8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40E9738515C8 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:2418::612 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736967329; cv=pass; b=W79Drre3sYgRdrJ6Zuaw5Hhx8sAeqFCSQHl1fZ0gC/xEP5hznHBWCG0+XwWC+AsiYpdAYMYdom5On0UptZ+ErJICydyCe+mnyx7EdibDdlYd1ugSoMka6xcm6qUEyMmsjCLqzkDWFPNcGJFtQ5wI/RNzJ1oIfgQjtaFDNomg8vc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1736967329; c=relaxed/simple; bh=d1TZ/NGeAuq9Q89NTxWsGH+1wE95if59vxzLl/9v1Rk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=VY6aR/xePl51Gu6YHaDAKDAVvDtmW4F+/+Esi9uGlTPFOFeVldx93JUHexWmCP7aGoMfi/cwTQNTmQTvLCYJUnmTa47o4Hus+NboNorsVexeEeWHdX85U+X37iSKc2hOzLRXP6nNWQ4OcXZXN3oE1BIs4JKsmq9R7nCl2V6eO6w= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 40E9738515C8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CGEptEhhE/C3sZumSEXSQ0K8XE9hA6+ZiKQbtMnGiavp23MptPh5s7zoDWF1gh94KwiinqMN9pcvGGLjtru+6s132CtD9H9TDbzmpRZuwdDqeIFRdDqJo5lApPrMY5eXo/sj8TJkZaYd/ke5yJbIp1O8wu6G6eLNzJz4yfNp3PgQ+5lkEahJqEumGq3J8E2pXgGsc7Vcvum0cJEvKcAgnn7468plS3oD8hC6k39Nc0rdM1Wjhcmagz99BsvCW8D1ovqTJiBELhE2OUCVk6PT30P0kuzafJCGbRF6mVydBPyefRSZqv2AnrIMrDQ2VF3hLN8aO8BhfyXE6ZajALm0vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZRahIt0W/0JtqRCKb0DE8jSMq/UCiBcbXVLpdk9ytHE=; b=hg5Ms1GSo4p54PUWSWrVhri12hKoltYbbMejYrkdjxhXxqRNBlkIeBRpaKflCWJA0MHWAa6UDBTAIUNDtdLgR4dNIgw1T8fo1D68U3rd8EQnWcJ3R7vAtTj8cRKFu1BQra+tpYkDlaR/DYsdiPu3xqx6PgteNTLwvdoIU+fHhbyJkECXukpxVaLKbmDNKGjyBlyUP6urYRmNgw+PSNTrbDnskMFm/MEEC5Vze09RUJKuExliNZ31v/K3bOIfJcJD9u7cA3ycueQbu0aF1wA4YugrSp1/Ioe5Z/ud3MtoVYjR5NY4mekGaKHLtjbhSQrKbatRiMPH0FW/SihBCZh8CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZRahIt0W/0JtqRCKb0DE8jSMq/UCiBcbXVLpdk9ytHE=; b=rVh/kXiqHzdOQu/HjYQu4otYozKIPleHWwSZQvB6avBtkAdlzd9DmX2N9fI62Sy8hhIkQ86bURtwQgUAcV1aaMfcrZg+GWtUmQzybt08zJp7W9hwQOODMwmLskh11aTfMdXc6Cwi4sPW1PmQXw0biybUeOArJKolSj4z5HbllDA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by CH3PR12MB8076.namprd12.prod.outlook.com (2603:10b6:610:127::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.12; Wed, 15 Jan 2025 18:55:25 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa%7]) with mapi id 15.20.8356.010; Wed, 15 Jan 2025 18:55:25 +0000 Message-ID: <31e4d88e-efd2-40d6-9dc6-d2bb475ca63e@amd.com> Date: Wed, 15 Jan 2025 18:55:20 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi References: <20250114191818.2393132-1-simon.marchi@polymtl.ca> <20250114191818.2393132-2-simon.marchi@polymtl.ca> <54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca> Content-Language: en-US From: Lancelot SIX In-Reply-To: <54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::18) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|CH3PR12MB8076:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f4ee5ef-14da-4331-bbfb-08dd35962b7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MXhwdk1kdXNHR3M5Ukkxa0R1cGVoaXk1SldkT3VSdmtYVktNMDdYbzlacjN6?= =?utf-8?B?K3BnMkg4Qk1TM1RFUUVtUENsVlFoWGtNQUZTakY2bVdhN0pOQm1iTTZWSkQz?= =?utf-8?B?cnpCWVVDK1VlM0FSZmZWS1U1OXpub05WMzdSUEZqYjR0MUFmYWtudWszTlhj?= =?utf-8?B?WHRrNlRjUG16QzhpZmZzVkt6OENDM05OWlVoU2w0MG9IUit4SlptWUhITVJz?= =?utf-8?B?aEtuTkQzWFNiUi9WK3RwVm0zazk0cFRXakdGZjdYUVFSQU1NNEp0Yk90WkRk?= =?utf-8?B?TUZwVzBBcWNIbDhvMW5WQU1JeEIwc3NWaGFWVUN0Z1ArZVAzUThvdDJDNXY5?= =?utf-8?B?eVZWZ2xUYVNFRlhQWVVEbkFqV2k4R0l0V2xRRXZVSmk5alllaXZaTjFUQmJI?= =?utf-8?B?czkrY3JzNzhRamRIb1hWeXBxRlJWWFBQSlI0TVNaUGJvT29DTTFqTm04YzJJ?= =?utf-8?B?dllEOTRMQVRUbVZqQ3dUajFEWkJ6YklTaHJsN2tocWxmWHdKOFJqTnNHcVVa?= =?utf-8?B?dm0xV05WQnRDOHNFTDJhajZNQ3hkb0ZRTDcwc0lqTFNxZ0t4ZU90bzZBUWI4?= =?utf-8?B?NWE4YWUvbEVLZ0lqMDZ6RFdmTzRvWldKSy9RWG1KSnAzRUZ4cmhkTzVZWjM0?= =?utf-8?B?bzdzbXNoV1pHR0VLZHVvc3BOUitLWDAvSDArM09qSHNNYkZGVlVuOEpMb1ho?= =?utf-8?B?Qk9KOXlJYVp3SFp2emRzQm85dUJlUnQzYm9oTWdGcTJIMFk3cmFSbTJadVp6?= =?utf-8?B?Q05nYVE4NFN4d1pNWE9leXZ3a2xIL1ZWSm1BS0lMYjdpbzhvUGdNdGd1cE5l?= =?utf-8?B?eXNkbFRZRVJiSnpReG05NHFoSjJTUlhKZWJpK05BQyt6SVdNTy8zMnFUa3hm?= =?utf-8?B?YnlhQlE0c0o1RnR0RmdrcXo2VnVQbll5Y1UwQTY5SFhFUUF1YjhCaVVEaTYx?= =?utf-8?B?MFhPdUd4SjlSZjNscHR5YWhLZWJxMmYvdDJtWlZObUF2c254VWsyek5oZmtU?= =?utf-8?B?R2xWaUZwSlZNclg0OWVIZmVoZmE2dksvNGVTYyszVWpyNW9Yb2pnempEellD?= =?utf-8?B?dm5Nc2VOb3FJTnpIbGtyYVhMWURGcTFhb0s0K2hBNXI4dWdPVUU0eUdyb3lC?= =?utf-8?B?NFZNOUgyTWtLSFdYVmEzbUNLWE5hY3FObjFQaHA4eWpRUlh2VnRma0dybWdF?= =?utf-8?B?ME81cUJ2cWlTNDJHclNiUmxUbUhFd0c5M0RsOC9sdXprT3VacWVNNWozWTRa?= =?utf-8?B?bEhXa2ppU1VzQ1lIb3I3WDZ0Q2JyRk5wRmNXbVBiWUtuR3VVQ3NLQ0h2UnFK?= =?utf-8?B?SVBVTGNqc1AwaXZHN0o0Njg3SlpPRXF2alhtRmtOeWVxaHFIbjI3enFHZnE2?= =?utf-8?B?ZVUwY3lhNzlBVXN4dXBCZjcxWmZYeWRBYlFHNFdCc1M4cmZJZnU0YjBnbnI5?= =?utf-8?B?R21jd3djeFV1UFNRWm0zcTlpRzVjckNnWGV3ODM5UW1SZXhlR0dWZzZpaXZn?= =?utf-8?B?SVdlbjRNdFNoRWU0K1pCU0lEVHY5cnh4ME5Db1BhSkJKVXFEY1NWSmc1dGhJ?= =?utf-8?B?S2hlVW9DK2VYUnFIMUtwR2J2eTJneEVleGU3WUJwYzBsQ3ppOTYwRWJyM0xL?= =?utf-8?B?SzRqcGpkU3grMnc2b2Z0dE1LZkRNbDIvOXp4RnRSYU03bmsydzdSVzJDS3l6?= =?utf-8?B?T01jTnUxUDIrYzEyM09zemFHWXZHZE1HT0xUaSsrMWNKaWQ5OVdVdEIvcUV4?= =?utf-8?B?bEU1MWovekdaYXJaMlRlQk9GT3FXcU02NHF0SlVVekozWlg5ZlprWUMrODVz?= =?utf-8?B?QlV4TFJuak5jS2ZiYWFTUnNQMlZtM2VhbmR3NTgreFdyVTRHVTF1UEFHbExJ?= =?utf-8?Q?pRi6FEsMHBRpT?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXJveXE4eTBLYzhpWnFmSGtHSG1vVFRySW9wOEdERStuWDk0RlpuOVpGTUlx?= =?utf-8?B?d3lmUnR1M1BXbmZyN0NyemhRb0NXZW8yUWlQTDFHNVBPL1JVbXVpdVFtVFJx?= =?utf-8?B?aUtyeERJMU56aWJIU1pLc2NCVG5VZlBlRFNUbjF1bW1OWVlmdlBoYks3N0Qr?= =?utf-8?B?V3laSmZBSWkxWTdMQlhOelYvU0xFU2haQVhPZWlxalMvUjZ5RnNNRU90MkJG?= =?utf-8?B?TkVFVkFPN29rNmtEQVVlREQ3TlhDcjczbVVUTkpmUUtMa3FQSzRJMUlCY2ZZ?= =?utf-8?B?NHJheGxsVzFOR1Z0MkFNN3l6Vm84N3BnTGcyZHd6N1FiR2FGYVlJczVlOVV3?= =?utf-8?B?SU9TdU9TcGVWLzA5MHJLM1cvS25PNWxKYmNkNlUxVm13TlY2WUZDWXdVQTNS?= =?utf-8?B?THNPSERsUlhLNjdtaSszck5IdVNtV3h6RkFqRWZ1Nlh6MEs1Snl3c0hkVnZN?= =?utf-8?B?UWVuL1BVRkdyNlZKOTlySnhSTy9RSjh1NkNBRVY2d2dkTzFLS0NLdGhFekpK?= =?utf-8?B?ZmtucG96NFZFMVpPVU1iT2RpWEhjdHlCdzhaRnJUTEQvSnpIYU9LWS9mVUdN?= =?utf-8?B?Z0toUVQyR3grdnR5Wm4wcWc5OE1nejkzbEFNeVpYQkpORVRrYno2M2prc2Y5?= =?utf-8?B?ZTlSN0w0MkZYazBsYUxKSVdUOTZZMzk1R1BBdDE2THluVWFwNndBQW1HclNX?= =?utf-8?B?RWx3ZlN4cDBFK2daRWhsMGhQdXB4ellHbHpVeUMzVElJaW5FcWhVV3RxaWl2?= =?utf-8?B?UkVFS1NYZWlLOVNJSStKZ0VCRGVFWGR3Vm1BeWorbWttcTQveEF3NWJ6U3c0?= =?utf-8?B?eXczd3JydFZONnZHMTl3eWx1Vjk1VkNlKzF0cEFLblI0U2xRL1hhR0J6eDN6?= =?utf-8?B?UWhnbDBVWEhvWFZMVHgyRXVzOUNDd1VZUzNteDZvaTJYWGREakZQeG9LVTNi?= =?utf-8?B?bHIzZlI3b21mVDlRSVFqVlJFMUlBb25WRmU5ZGYzaDMyY1B5c2hrNGxOUVZ1?= =?utf-8?B?RlpCUXRqUG1MTmIwRHJCcURhSElSNlpWaHk0dUl2M1hubktDSVdqY3U4Rkdr?= =?utf-8?B?MW4zaDAzTnVIN1ptdGZpS3J3SzVQOHpON2NXQTdnVW1vdlovbE13V3NHSG9n?= =?utf-8?B?OWowbGtFMDRHY3ZRSHF3elM5ZlJVamV0aU1IVEJ0aVlZbVIvTko3a0s5bDdu?= =?utf-8?B?dzJPMWNFNDM1UWxQSG1ubXE0MG9QUFRnQ2pLbEsrU3ZGam5qa0x0ajBPcTlh?= =?utf-8?B?VUh3UGVYRHdyVEZpVzduVjdaNk5jb0NSdVoyVkZVUFFVblc2ajB1ak92aGVv?= =?utf-8?B?WlRWMzA2UEZXdk5VaGQwbHNGWmtjbTNUMDRLMnRZN0xTVXFwTVhQM3VlYWdV?= =?utf-8?B?ODJwUXdIR0tCNk1Kd0dBNEhtTTBBajAyelYwZWU5djJsVEhYVGlFdGV6eWsv?= =?utf-8?B?bXkwM0wvQVVCWkRGdkxyS0Ywem82RXBuV3F4ZWRqTElCV3Rpem5aenk3cEwz?= =?utf-8?B?VitmL1o0c3RQZ1ZpbnFQbXBCaURzb055NWR2N3lxMFBuWi92S2VtL01nNnkz?= =?utf-8?B?ZjZMNkdvZ3JhbEkrN3dWVWZMZ1phU1l6RGYyWGY5MDNXN21lQ0JpV292bTBt?= =?utf-8?B?Tmo4Z2pKZ2lkblcrTWdiWlB0OUZvbjg2d1NPWVg3RHh0RVZQcHhkKzFwOXo2?= =?utf-8?B?b21YYTB4Q0RlM2V3d1ZhRC9iTlBMYUF3Y0FHTzhxWnkzV0pIbUtQakhkQ2ZL?= =?utf-8?B?YTFVc2ZVaURIYWovQTBMUnAybVRGbis4NmJlUnlibjVOUkhsRnBOQW9YbTVi?= =?utf-8?B?VUhrUHA3UThnM3M2RGVFcXkxbzdTVVhacHZHUHFkZUxQTEVVYTJ6YWs4N1hW?= =?utf-8?B?RnVCZVk5SmlyZGVVZFZVM3hLaUtaeTB3dTZONTR4Q3dMdWZYck1Bb3hRWE0w?= =?utf-8?B?KzNsYStHUkYxd3d1WUNyY2JNOUhXeDRSOEoyNkVCazRCN2kydkJuOU5KUmZl?= =?utf-8?B?ZGZyMHJwVXdMVnhvZU15YkNrYWtuSzFkTWgvNkdJSXBZamYwY1V2bW8xcjJi?= =?utf-8?B?YmRxZHZqK0VuUlZGaS9sS1RTaDMxYlkraHVHTFpxallabTNoTjdaVnowQ256?= =?utf-8?Q?LGelw3+frw5vONUkCEYD1ETZd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f4ee5ef-14da-4331-bbfb-08dd35962b7e X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 18:55:24.9476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BkzgKQscksjYns4MZGZBvbiZRkJAV8GWvy8W3k/mmDSYrrrjqwhCa44OnngumMvL+vRMuRlQskf7iiHiji6WsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8076 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 15/01/2025 18:41, Simon Marchi wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On 2025-01-15 05:55, Lancelot SIX wrote: >> >> >> On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote: >>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. >>> >>> >>> From: Simon Marchi >>> >>> Since we have gdb::unordered_map, swap std::unordered_map for that. >>> >> >> Hi, >> >> That looks good to me, thanks. >> >> Since it only touches the amdgpu backend, >> Approved-By: Lancelot Six (amdgpu) > > Thanks, added. > > Is the (amdgpu) some format we use? I haven't seen it used anywhere > else. I don't mind, for instance, Eli could use Approved-By with (doc). > > Simon This was discussed when introducing the trailer tags for reviews, and is documented in the gdb/MAINTAINERS file (thanks Gwen for that). - Approved-By: […] This trailer can be specific to one or more areas of the project, as defined by the "Responsible maintainers" section of this file. If that is the case, the area(s) should be added at the end of the tag in parenthesis in a comma separated list. There are a couple of other instances of that already: $ git log origin/master |grep -i Approved-by: | sort |uniq|grep \( Approved-By: G... L... <...> (record-full) Approved-By: L... S... <...> (amdgpu) Approved-By: L... M... <...> (aarch64/arm) Best, Lancelot.