From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +5DTCn4BiGfINRAAWB0awg (envelope-from ) for ; Wed, 15 Jan 2025 13:42:06 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=ptwhDtgK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1B0871E05C; Wed, 15 Jan 2025 13:42:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A3991E05C for ; Wed, 15 Jan 2025 13:42:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF76B3851A8B for ; Wed, 15 Jan 2025 18:42:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF76B3851A8B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=ptwhDtgK Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 30D27385DDCD for ; Wed, 15 Jan 2025 18:41:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30D27385DDCD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30D27385DDCD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736966492; cv=none; b=idSMrKlPl4C1NdpZmnc8dcrnWSuC9+UFtOKJ34DaXlD2U6EfeTdm/0oA3ru4+BiklMbAEXy2c0RS1mW3lkcbx/HwbMhMmdTyejzEgN2P2Mvk10lOHD6eYMuG4HHy7S7FvpU2n//CF7+XcTk8tGzH8AdZiElB3ctBNjKQp0tmZ6E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736966492; c=relaxed/simple; bh=iTMY5uTD69Tnd5JFEKoZdrlQO0Fk3zAS/kmr595hSbE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Yh0YTv0ZUrIkS4Ur3A5Nj9DurFhRnaNbf6mxqrV7oJ0zJF7p7O4rguaLRIDdvSYIaAoMuRnbGsa5xRWu7gUIU7Ja0ZmHbc2vBW8EatkAVqyMUyYGOgNi6zviOHVjaPoOnhP4RwSvlAtRVIgBSsDg/DlRdP7GUxLNRDe8FuvsOqI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 30D27385DDCD Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 50FIfQGP130126 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 15 Jan 2025 13:41:31 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 50FIfQGP130126 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1736966491; bh=DCm7V7lWpgm+p9T8pkZoox395+/hrz4A0UCC71uhTIo=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=ptwhDtgKNal0vh2Ppszi5fiRMaONeiwnpIk7W2LIB4inuZF1eHH1nO+8lXIpgBE+S trTJy/jOQ+5Ldf6fJFLA8THTsfNPrceOLtsVgGBDDeQVAWTGMy7Y2el0hdJpCRHb1m UC1KfcQ4/+qOpo/3cU6R04NnsGjEbHmApbubeMXg= Received: by simark.ca (Postfix, from userid 112) id BDCEA1E105; Wed, 15 Jan 2025 13:41:26 -0500 (EST) Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 879161E05C; Wed, 15 Jan 2025 13:41:25 -0500 (EST) Message-ID: <54cff523-f8b8-4066-aadf-e1ab0381a821@polymtl.ca> Date: Wed, 15 Jan 2025 13:41:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gdb/amd-dbgapi: use gdb::unordered_map To: Lancelot SIX , gdb-patches@sourceware.org Cc: Simon Marchi References: <20250114191818.2393132-1-simon.marchi@polymtl.ca> <20250114191818.2393132-2-simon.marchi@polymtl.ca> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 15 Jan 2025 18:41:26 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-01-15 05:55, Lancelot SIX wrote: > > > On 14/01/2025 19:16, simon.marchi@polymtl.ca wrote: >> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. >> >> >> From: Simon Marchi >> >> Since we have gdb::unordered_map, swap std::unordered_map for that. >> > > Hi, > > That looks good to me, thanks. > > Since it only touches the amdgpu backend, > Approved-By: Lancelot Six (amdgpu) Thanks, added. Is the (amdgpu) some format we use? I haven't seen it used anywhere else. I don't mind, for instance, Eli could use Approved-By with (doc). Simon